소스 검색

Roxie memory leaks

Roxie leaks a DataMemoryBuffer per ping received when pingInterval is non-zero.
Also if udpRetryEnabled is false, all outboud packets are leaked (!).

This commit partially addresses gh-1358, but does NOT address the issue of ping
responses causing the retry queue to fill up. Until that is also fixed, it is
probably safest to keep pingInterval set at 0.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Richard Chapman 13 년 전
부모
커밋
02e814b343
2개의 변경된 파일5개의 추가작업 그리고 0개의 파일을 삭제
  1. 1 0
      roxie/ccd/ccdqueue.cpp
  2. 4 0
      roxie/udplib/udptrs.cpp

+ 1 - 0
roxie/ccd/ccdqueue.cpp

@@ -2724,6 +2724,7 @@ public:
                 }
                 else
                     DBGLOG("PING reply, garbled result");
+                ReleaseRoxieRow(answer);
             }
             else if (!anyActivity)
             {

+ 4 - 0
roxie/udplib/udptrs.cpp

@@ -269,6 +269,10 @@ public:
                 }
                 retryData[slot] = buffer;
             }
+            else
+            {
+                ::Release(buffer);
+            }
         }
         return totalSent;
     }