Merge pull request #12917 from miguelvazq/HPCC-21272

HPCC-22172 Remove open buttons from GridDetails

Reviewed-By: Gordon Smith <gordon.smith@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>

esp/src/eclwatch/PreflightDetailsWidget.js

@@ -43,9 +43,8 @@ define([
 
             createGrid: function (domID) {
                 var context = this;
-
-                this.openButton = registry.byId(this.id + "Open");
-                this.openButton.set("disabled", true);
+                dojo.destroy(this.id + "Open");
+                dojo.destroy(this.id + "RemovableSeperator2");
 
                 var retVal = new declare([ESPUtil.Grid(true, false, {rowsPerPage:1000}, true)])({
                     store: this.store,

esp/src/eclwatch/TopologyWidget.js

@@ -225,7 +225,6 @@ define([
                     label: this.i18n.TargetClusters
                 }).placeAt(this.openButton.domNode, "after");
 
-                new ToolbarSeparator().placeAt(this.openButton.domNode, "after");
                 new ToolbarSeparator().placeAt(this.viewModeMachines.domNode, "after");
 
                 this.machineInformationDropDown = this.createLabelAndElement("machineinformation", "Machine Information", "Select", this.i18n.MachineInformation, [{ label: this.i18n.MachineInformation, value: "GetMachineInfo", selected: true }])

esp/src/eclwatch/XrefErrorsWarningsWidget.js

@@ -43,7 +43,7 @@ define([
             createGrid: function (domID) {
                 this.openButton = registry.byId(this.id + "Open");
                 dojo.destroy(this.id + "Open");
-                dojo.destroy("dijit_ToolbarSeparator_18");
+                dojo.destroy(this.id + "RemovableSeperator2");
 
                 var retVal = new declare([ESPUtil.Grid(true, true)])({
                     store: this.store,

esp/src/eclwatch/templates/GridDetailsWidget.html

@@ -4,10 +4,10 @@
             <div id="${id}_Grid" style="width: 100%; height: 100%" data-dojo-props='title:"${gridTitle}"' data-dojo-type="dijit.layout.BorderContainer">
                 <div id="${id}Toolbar" class="topPanel" data-dojo-props="region: 'top'" data-dojo-type="dijit.Toolbar">
                     <div id="${id}Refresh" data-dojo-attach-event="onClick:_onRefresh" data-dojo-props="iconClass:'iconRefresh'" data-dojo-type="dijit.form.Button">${i18n.Refresh}</div>
-                    <span data-dojo-type="dijit.ToolbarSeparator"></span>
+                    <span id="${id}RemovableSeperator1" data-dojo-type="dijit.ToolbarSeparator"></span>
                     <div id="${id}Open" data-dojo-attach-event="onClick:_onOpen" data-dojo-type="dijit.form.Button">${i18n.Open}</div>
                     <span id="${id}ContainerNode" data-dojo-attach-point="containerNode"></span>
-                    <span data-dojo-type="dijit.ToolbarSeparator"></span>
+                    <span id="${id}RemovableSeperator2" data-dojo-type="dijit.ToolbarSeparator"></span>
                     <div class="right" data-dojo-attach-event="onChange:_onMaximize" data-dojo-props="iconClass:'iconMaximize', showLabel:false" checked=false data-dojo-type="dijit.form.ToggleButton">${i18n.MaximizeRestore}</div>
                     <div id="${id}NewPage" class="right" data-dojo-attach-event="onClick:_onNewPage" data-dojo-props="iconClass:'iconNewPage', showLabel:false" data-dojo-type="dijit.form.Button">${i18n.OpenInNewPage}</div>
                 </div>