소스 검색

HPCC-25950 Institute lower default log level

- Updates global default log level
- Updates helm chart global default log level
- Updates logging README

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
Rodrigo Pastrana 4 년 전
부모
커밋
1192e492f3
6개의 변경된 파일4개의 추가작업 그리고 10개의 파일을 삭제
  1. 0 2
      dali/sasha/saserver.cpp
  2. 1 3
      dali/server/daserver.cpp
  3. 1 1
      helm/examples/logging/README.md
  4. 1 1
      helm/hpcc/values.yaml
  5. 0 2
      roxie/roxie/roxie.cpp
  6. 1 1
      system/jlib/jlog.hpp

+ 0 - 2
dali/sasha/saserver.cpp

@@ -298,8 +298,6 @@ static constexpr const char * defaultYaml = R"!!(
 version: 1.0
 version: 1.0
 sasha:
 sasha:
   name: sasha
   name: sasha
-  logging:
-    detail: 100
 )!!";
 )!!";
 
 
 int main(int argc, const char* argv[])
 int main(int argc, const char* argv[])

+ 1 - 3
dali/server/daserver.cpp

@@ -398,8 +398,6 @@ version: 1.0
 dali:
 dali:
   name: dali
   name: dali
   dataPath: "/var/lib/HPCCSystems/dalistorage"
   dataPath: "/var/lib/HPCCSystems/dalistorage"
-  logging:
-    detail: 100
 )!!";
 )!!";
 
 
 
 
@@ -652,7 +650,7 @@ int main(int argc, const char* argv[])
         Owned<IMPServer> mpServer = getMPServer();
         Owned<IMPServer> mpServer = getMPServer();
         Owned<IAllowListHandler> allowListHandler = createAllowListHandler(populateAllowListFromEnvironment, formatDaliRole);
         Owned<IAllowListHandler> allowListHandler = createAllowListHandler(populateAllowListFromEnvironment, formatDaliRole);
         mpServer->installAllowListCallback(allowListHandler);
         mpServer->installAllowListCallback(allowListHandler);
-        setMsgLevel(fileMsgHandler, serverConfig->getPropInt("SDS/@msgLevel", 100));
+        setMsgLevel(fileMsgHandler, serverConfig->getPropInt("SDS/@msgLevel", DebugMsgThreshold));
 #endif
 #endif
         startLogMsgChildReceiver();
         startLogMsgChildReceiver();
         startLogMsgParentReceiver();
         startLogMsgParentReceiver();

+ 1 - 1
helm/examples/logging/README.md

@@ -46,7 +46,7 @@ The available target categories include disaster(DIS), error(ERR), warning(WRN),
     helm install myhpcc ./hpcc --set dali[0].logging.classes="ALL-PRO" --set dali[0].name="mydali"
     helm install myhpcc ./hpcc --set dali[0].logging.classes="ALL-PRO" --set dali[0].name="mydali"
 
 
 ### Log Detail Level Configuration
 ### Log Detail Level Configuration
-Log output verbosity can be adjusted from "critical messages only" (1) up to "report all messages" (100). By default, the log level is set highest (100). 
+Log output verbosity can be adjusted from "critical messages only" (1) up to "report all messages" (100). The default log level is rather high (80) and should be adjusted accordingly.
 
 
     For example, verbosity should be medium for all components:
     For example, verbosity should be medium for all components:
     helm install myhpcc ./hpcc --set global.logging.detail="50"
     helm install myhpcc ./hpcc --set global.logging.detail="50"

+ 1 - 1
helm/hpcc/values.yaml

@@ -13,7 +13,7 @@ global:
 
 
   # logging sets the default logging information for all components. Can be overridden locally
   # logging sets the default logging information for all components. Can be overridden locally
   logging:
   logging:
-    detail: 100
+    detail: 80
 
 
   # Specify a defaultEsp to control which eclservices service is returned from Std.File.GetEspURL, and other uses
   # Specify a defaultEsp to control which eclservices service is returned from Std.File.GetEspURL, and other uses
   # If not specified, the first esp component that exposes eclservices application is assumed.
   # If not specified, the first esp component that exposes eclservices application is assumed.

+ 0 - 2
roxie/roxie/roxie.cpp

@@ -51,8 +51,6 @@ roxie:
   localSlave: true
   localSlave: true
   numChannels: 1
   numChannels: 1
   queueNames: roxie.roxie
   queueNames: roxie.roxie
-  logging:
-    detail: 100
 )!!";
 )!!";
 
 
 int main(int argc, const char *argv[])
 int main(int argc, const char *argv[])

+ 1 - 1
system/jlib/jlog.hpp

@@ -239,7 +239,7 @@ inline unsigned LogMsgClassFromAbbrev(char const * abbrev)
 }
 }
 
 
 typedef unsigned LogMsgDetail;
 typedef unsigned LogMsgDetail;
-#define DefaultDetail   100
+#define DefaultDetail   DebugMsgThreshold
 #define TopDetail (LogMsgDetail)-1
 #define TopDetail (LogMsgDetail)-1
 
 
 /*
 /*