Merge pull request #4762 from GordonSmith/HPCC-9899

HPCC-9899 Ensure all FOR loops use local variables 

Reviewed-By: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>

esp/files/scripts/ECLPlaygroundWidget.js

@@ -106,7 +106,7 @@ define([
             if (params.Wuid) {
                 this.wu = ESPWorkunit.Get(params.Wuid);
                 var data = this.wu.getData();
-                for (key in data) {
+                for (var key in data) {
                     this.updateInput(key, null, data[key]);
                 }
                 this.watchWU();

esp/files/scripts/ESPRequest.js

@@ -237,7 +237,7 @@ define([
                 delete target[arrayName];
                 var singularName = arrayName.substr(0, arrayName.length - 1);
                 var i = 0;
-                for (key in appData) {
+                for (var key in appData) {
                     target[arrayName + "." + singularName + "." + i + '.Application'] = "ESPRequest.js";
                     target[arrayName + "." + singularName + "." + i + '.Name'] = key;
                     target[arrayName + "." + singularName + "." + i + '.Value'] = appData[key];

esp/files/scripts/ESPResult.js

@@ -164,7 +164,7 @@ define([
                 for (var i = 0; i < cell.length; ++i) {
                     if (i == 0) {
                         var tr = domConstruct.create("tr", null, table);
-                        for (key in cell[i]) {
+                        for (var key in cell[i]) {
                             var th = domConstruct.create("th", { innerHTML: entities.encode(key) }, tr);
                         }
                     }

esp/files/scripts/GraphWidget.js

@@ -256,7 +256,7 @@ require([
                     var first = true;
                     var table = {};
                     var tr = {};
-                    for (key in props) {
+                    for (var key in props) {
                         if (key[0] == "_")
                             continue;
 

esp/files/scripts/LFDetailsWidget.js

@@ -162,7 +162,7 @@ define([
             if (params.Name) {
                 this.logicalFile = ESPLogicalFile.Get(params.Name);
                 var data = this.logicalFile.getData();
-                for (key in data) {
+                for (var key in data) {
                     this.updateInput(key, null, data[key]);
                 }
                 this.logicalFile.watch(function (name, oldValue, newValue) {

esp/files/scripts/LZBrowseWidget.js

@@ -362,7 +362,7 @@ define([
                 getSelected: function () {
                     var retVal = [];
                     var store = FileSpray.CreateFileListStore();
-                    for (key in this.selection) {
+                    for (var key in this.selection) {
                         retVal.push(store.get(key));
                     }
                     return retVal;

esp/files/scripts/SFDetailsWidget.js

@@ -139,7 +139,7 @@ define([
             if (params.Name) {
                 this.logicalFile = ESPLogicalFile.Get(params.Name);
                 var data = this.logicalFile.getData();
-                for (key in data) {
+                for (var key in data) {
                     this.updateInput(key, null, data[key]);
                 }
                 this.logicalFile.watch(function (name, oldValue, newValue) {

esp/files/scripts/WUDetailsWidget.js

@@ -168,7 +168,7 @@ define([
                 dom.byId(this.id + "Wuid").innerHTML = params.Wuid;
                 this.wu = ESPWorkunit.Get(params.Wuid);
                 var data = this.wu.getData();
-                for (key in data) {
+                for (var key in data) {
                     this.updateInput(key, null, data[key]);
                 }
                 var context = this;