Fix some cosmetic issues picked up by cppccheck

Some minor changes to the code as suggested by cppcheck. None
have any material effect.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>

system/jlib/jcomp.cpp

@@ -89,8 +89,6 @@ static const char * CC_OPTION_RELEASE[] = { "/Zm500 /EHsc /GR /Oi /Ob1 /GF /nolo
 static const char * DLL_LINK_OPTION_RELEASE[] = { "/BASE:" BASE_ADDRESS " /NOLOGO /LARGEADDRESSAWARE /INCREMENTAL:NO", "-shared -L. -fPIC -pipe -O0" };
 static const char * EXE_LINK_OPTION_RELEASE[] = { "/BASE:" BASE_ADDRESS " /NOLOGO /LARGEADDRESSAWARE /INCREMENTAL:NO", "-L. -Wl,-E -fPIC -pipe -O0" };
 
-static const char * CC_COMPILE_ONLY[] = { " /c", " <TBD> " };
-
 static const char * LINK_TARGET[] = { " /out:", " -o " };
 static const char * DEFAULT_CC_LOCATION[] = { ".", "." };
 

system/jlib/jptree.cpp

@@ -5147,14 +5147,6 @@ IPropertyTree *createPTreeFromXMLString(unsigned len, const char *xml, byte flag
 //////////////////////////
 /////////////////////////
 
-    
-static int compareStrings(CInterface **ll, CInterface **rr)
-{
-    StringAttrItem *l = (StringAttrItem *) *ll;
-    StringAttrItem *r = (StringAttrItem *) *rr;
-    return stricmp(l->text, r->text);
-};
-
 static void _toXML(const IPropertyTree *tree, IIOStream &out, unsigned indent, byte flags)
 {
     const char *name = tree->queryName();

system/jlib/jregexp.cpp

@@ -1536,7 +1536,7 @@ void addActionList(StringMatcher & matcher, const char * text, unsigned action,
                     }
                     break;
                 default:
-                    ;//otherwise \ just quotes the character e.g. \,
+                    break; //otherwise \ just quotes the character e.g. \,
                 }
             }
             str.append(next);

system/jlib/jsocket.cpp

@@ -3296,6 +3296,7 @@ bool SocketListParser::next(StringAttr & ip, unsigned & port)
                 goto done;
             case '.':
                 ++count;
+                break;
             }
         }
 done:
@@ -4232,6 +4233,7 @@ bool catchReadBuffer(ISocket * socket, MemoryBuffer & buffer)
             break;
         default:
             EXCLOG(e,"catchReadBuffer");
+            break;
         }
         e->Release();
     }
@@ -4253,6 +4255,7 @@ bool catchReadBuffer(ISocket * socket, MemoryBuffer & buffer, unsigned timeoutms
             break;
         default:
             EXCLOG(e,"catchReadBuffer");
+            break;
         }
         e->Release();
     }
@@ -4512,6 +4515,7 @@ public:
                     break;
                 default:
                     state = Scancelled;
+                    break;
                 }
             }
             catch (IException *e) {

system/jlib/junicode.cpp

@@ -605,7 +605,7 @@ void addUtfActionList(StringMatcher & matcher, const char * text, unsigned actio
                     }
                     break;
                 default:
-                    ;//otherwise \ just quotes the character e.g. \,
+                    break; //otherwise \ just quotes the character e.g. \,
                 }
             }
             str.append(next);

system/jlib/jutil.cpp

@@ -2111,7 +2111,7 @@ jlib_decl StringBuffer& encodeUrlUseridPassword(StringBuffer& out, const char* i
           case '&': out.append("%26"); break;
           case ' ': out.append("%20"); break;
         */
-        default: out.append(*p);
+        default: out.append(*p); break;
         }
     }
     return out;