Merge pull request #12344 from jakesmith/hpcc-21722

HPCC-21722 hthor jobs could ignore AlwaysECL translate option

ecl/hthor/hthor.cpp

@@ -8063,17 +8063,17 @@ void CHThorDiskReadBaseActivity::ready()
     IDistributedFile *dFile = nullptr;
     if (ldFile)
         dFile = ldFile->queryDistributedFile();  // Null for local file usage
+
+    Linked<IOutputMetaData> publishedMeta = actualDiskMeta;
+    unsigned publishedCrc = actualCrc;
     if (dFile)
     {
         IPropertyTree &props = dFile->queryAttributes();
-        Owned<IOutputMetaData> publishedMeta = getDaliLayoutInfo(props);
+        publishedMeta.setown(getDaliLayoutInfo(props));
         if (publishedMeta)
-        {
-            actualDiskMeta.setown(publishedMeta.getClear());
-            actualCrc = props.getPropInt("@formatCrc");
-        }
+            publishedCrc = props.getPropInt("@formatCrc");
     }
-    translators.setown(::getTranslators("hthor-diskread", expectedCrc, expectedDiskMeta, actualCrc, actualDiskMeta, projectedCrc, projectedDiskMeta, getLayoutTranslationMode()));
+    translators.setown(::getTranslators("hthor-diskread", expectedCrc, expectedDiskMeta, publishedCrc, publishedMeta, projectedCrc, projectedDiskMeta, getLayoutTranslationMode()));
     if (translators)
     {
         translator = &translators->queryTranslator();
@@ -8355,7 +8355,9 @@ bool CHThorDiskReadBaseActivity::openNext()
                             }
                             catch (IException *e)
                             {
+#ifdef _DEBUG
                                 EXCLOG(e, nullptr);
+#endif
                                 e->Release();
                                 continue; // try next copy and ultimately failover to local when no more copies
                             }

thorlcr/activities/diskread/thdiskreadslave.cpp

@@ -325,7 +325,9 @@ void CDiskRecordPartHandler::open()
                 }
                 catch (IException *e)
                 {
+#ifdef _DEBUG
                     EXCLOG(e, nullptr);
+#endif
                     e->Release();
                     continue; // try next copy and ultimately failover to local when no more copies
                 }

thorlcr/activities/indexread/thindexreadslave.cpp

@@ -239,7 +239,9 @@ public:
                             }
                             catch (IException *e)
                             {
+#ifdef _DEBUG
                                 EXCLOG(e, nullptr);
+#endif
                                 e->Release();
                                 continue; // try next copy and ultimately failover to local when no more copies
                             }