HPCC-18293 Remove the no longer needed ESPuses HIDL feature

The ESPuses feature hasn't been needed for years, and it can cause
problems with interface versioning.

Signed-off-by: Anthony Fishbeck <anthony.fishbeck@lexisnexis.com>

esp/scm/WsDeploy.ecm

@@ -570,11 +570,6 @@ ESPresponse [exceptions_inline, encode(0)] GetSummaryResponse
 
 ESPservice [auth_feature("NONE"), exceptions_inline("xslt/exceptions.xslt")] WsDeploy
 {
-    ESPuses ESPstruct Task;
-    ESPuses ESPstruct Component;
-    ESPuses ESPstruct DeployOptions;
-    ESPuses ESPstruct DeployInfo;
-
     ESPmethod[description("Handle an event from the navigation tree menu"), help("")] 
         NavMenuEvent(NavMenuEventRequest, NavMenuEventResponse);    
     ESPmethod[description("Dependency graph"), help(""), resp_xsl_default("xslt/graph_display.xsl")] 

esp/scm/ws_dfu.ecm

@@ -749,12 +749,6 @@ ESPservice [
     noforms,
     exceptions_inline("./smc_xslt/exceptions.xslt")] WsDfu
 {
-    ESPuses ESPStruct DFULogicalFile;
-    ESPuses ESPStruct DFUPart;
-    ESPuses ESPStruct DFUFileStat;
-    ESPuses ESPStruct DFUFileDetail;
-    ESPuses ESPStruct DFUDataColumn;
-
     ESPmethod [resp_xsl_default("/esp/xslt/dfu_fileview.xslt")] DFUFileView(DFUFileViewRequest, DFUFileViewResponse);
     ESPmethod [resp_xsl_default("/esp/xslt/dfu_search.xslt")] DFUSearch(DFUSearchRequest, DFUSearchResponse);
     ESPmethod [resp_xsl_default("/esp/xslt/dfu.xslt")] DFUQuery(DFUQueryRequest, DFUQueryResponse);

esp/scm/ws_fileio.ecm

@@ -74,7 +74,6 @@ ReadFileDataResponse
 
 ESPservice [auth_feature("DEFERRED"), exceptions_inline("./smc_xslt/exceptions.xslt")] WsFileIO
 {
-    //ESPuses ESPstruct DFUException;
     ESPmethod CreateFile(CreateFileRequest, CreateFileResponse);
     ESPmethod WriteFileData(WriteFileDataRequest, WriteFileDataResponse);
     ESPmethod ReadFileData(ReadFileDataRequest, ReadFileDataResponse);

esp/scm/ws_fs.ecm

@@ -682,8 +682,6 @@ ESPservice [
     version("1.15"),
     exceptions_inline("./smc_xslt/exceptions.xslt")] FileSpray
 {
-    ESPuses ESPstruct DFUWorkunit;
-    ESPuses ESPstruct DFUException;
     ESPmethod EchoDateTime(EchoDateTime, EchoDateTimeResponse);
     ESPmethod [resp_xsl_default("/esp/xslt/showresult.xslt")] ShowResult(ShowResultRequest, ShowResultResponse);
     ESPmethod [resp_xsl_default("/esp/xslt/dfuwu_search.xslt")] DFUWUSearch(DFUWUSearchRequest, DFUWUSearchResponse);

esp/scm/ws_machine.ecm

@@ -370,14 +370,6 @@ ESPresponse [encode(0), nil_remove, exceptions_inline] UpdateComponentStatusResp
 //-------- service ---------
 ESPservice [auth_feature("DEFERRED"), version("1.13")] ws_machine
 {
-    ESPuses ESPstruct RequestInfoStruct;
-    ESPuses ESPstruct MachineInfoEx;
-    ESPuses ESPstruct ProcessorInfo;
-    ESPuses ESPstruct StorageInfo;
-    ESPuses ESPstruct SWRunInfo;
-    ESPuses ESPstruct RemoteExecResult;
-    ESPuses ESPStruct ComponentInfo;
-
     ESPmethod [resp_xsl_default("./smc_xslt/clusterprocesses.xslt"), exceptions_inline("./smc_xslt/exceptions.xslt")]
        GetTargetClusterInfo(GetTargetClusterInfoRequest, GetTargetClusterInfoResponse);
 

esp/scm/ws_topology.ecm

@@ -613,26 +613,6 @@ ESPresponse [nil_remove, exceptions_inline] TpDropZoneQueryResponse
 
 ESPservice [auth_feature("DEFERRED"), noforms, version("1.26"), exceptions_inline("./smc_xslt/exceptions.xslt")] WsTopology
 {
-    ESPuses ESPStruct TpBinding;
-    ESPuses ESPstruct TpCluster;
-    ESPuses ESPstruct TpDali;
-    ESPuses ESPstruct TpDfuServer;
-    ESPuses ESPstruct TpDropZone;
-    ESPuses ESPstruct TpEclAgent;
-    ESPuses ESPstruct TpEclServer;
-    ESPuses ESPstruct TpEspServer;
-    ESPuses ESPstruct TpFTSlave;
-    ESPuses ESPstruct TpDkcSlave;
-    ESPuses ESPstruct TpGroup;
-    ESPuses ESPstruct TpLdapServer;
-    ESPuses ESPStruct TpLogicalCluster;
-    ESPuses ESPstruct TpMachine;
-    ESPuses ESPstruct TpMySqlServer;
-    ESPuses ESPStruct TpQueryType;
-    ESPuses ESPStruct TpSashaServer;
-    ESPuses ESPstruct TpServices;
-    ESPuses ESPstruct TpTargetCluster;
-
     ESPmethod [cache_seconds(180), cache_global(1), resp_xsl_default("/esp/xslt/targetclusters.xslt")] TpTargetClusterQuery(TpTargetClusterQueryRequest, TpTargetClusterQueryResponse);
     ESPmethod [cache_seconds(180), cache_global(1), resp_xsl_default("/esp/xslt/topology.xslt")] TpClusterQuery(TpClusterQueryRequest, TpClusterQueryResponse);
     ESPmethod [cache_seconds(180), cache_global(1)] TpLogicalClusterQuery(TpLogicalClusterQueryRequest, TpLogicalClusterQueryResponse);

tools/hidl/hidlcomp.cpp

@@ -5801,13 +5801,6 @@ void EspServInfo::write_esp_binding()
     }
     outs("\tDBGLOG(\"Client version: %g\", context.getClientVersion());\n");
 
-    // kept for backward compatible
-    EspStructInfo *sti=NULL;
-    for (sti=structs;sti!=NULL;sti=sti->next)
-    {
-        outf("\tC%s::getXsdDefinition(context, request, content, added);\n", sti->getName());
-    }
-    
     indentReset(1);
     outf(1, "bool fullservice = (!Utils::strcasecmp(service, \"%s\"));\n", name_);
     indentOuts("bool allMethods = (method==NULL || *method==0);\n");

tools/hidl/hidlcomp.h

@@ -1149,7 +1149,6 @@ public:
         methods=NULL;
         mounts=NULL;
         tags=NULL;
-        structs=NULL;
         next=NULL;
         needsXslt = false;
     }
@@ -1161,7 +1160,6 @@ public:
         if (base_)
             free(base_);
         
-        delete structs;
         delete methods;
         delete mounts;
         delete tags;
@@ -1216,7 +1214,6 @@ public:
     void write_catch_blocks(EspMethodInfo* mthi, catch_type ct, int indents);
     void write_clarion_include_interface();
 
-    EspStructInfo  *structs;
     EspMethodInfo   *methods;
     EspMountInfo    *mounts;
     MetaTagInfo     *tags;

tools/hidl/hidlgram.y

@@ -97,7 +97,6 @@ int  nCommentStartLine = -1;
   ESPVERSIONDEF
   ESPTEMPLATE
   ESPMOUNT
-  ESPUSES
   ESPDEFEXPORT
   XSDTYPE
   _CONST
@@ -209,7 +208,6 @@ EspServiceEntryList
 EspServiceEntry
  : EspServiceMethod
  | EspServiceMount
- | EspServiceUses
  ;
 
 EspServiceMethod
@@ -261,18 +259,6 @@ EspServiceMount
  }
  ;
 
-EspServiceUses
- : ESPUSES EspMetaData EspType ID ';'
- {
-    EspStructInfo *esp_struct=new EspStructInfo($4.getName());
-    
-    esp_struct->tags = getClearCurMetaTags();
-
-    esp_struct->next=CurService->structs;
-    CurService->structs=esp_struct;
- }
- ;
-
 EspStruct
  : EspStructStart OptionalExtends EspMessageBody ';'
  {

tools/hidl/hidllex.l

@@ -53,7 +53,6 @@ ESPservice  { if (check_return( ESPSERVICE )) return ESPSERVICE; }
 ESPmethod   { if (check_return( ESPMETHOD )) return ESPMETHODREF; else return ESPMETHOD; }
 ESPmount    { if (check_return( ESPMOUNT )) return ESPMOUNT; }
 ESParray    { yylval.setName((const char *) yytext); if (check_return( ESPTEMPLATE )) return ESPTEMPLATE; }
-ESPuses     { if (check_return( ESPUSES )) return ESPUSES; }
 EspInclude  { if (check_return( ESPINCLUDE )) return ESPINCLUDE; } //Kevin
 ESPVersionDef   { if (check_return( ESPVERSIONDEF )) return ESPVERSIONDEF; }
 const       { if (check_return( _CONST )) return _CONST; }