Przeglądaj źródła

Merge pull request #4192 from richardkchapman/roxie-unused-options

HPCC-9075 Clean up unused Roxie configuration settings

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Gavin Halliday 12 lat temu
rodzic
commit
29acf2fe4f

+ 0 - 91
initfiles/componentfiles/configxml/roxie.xsd.in

@@ -432,13 +432,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="allowRoxieOnDemand" type="xs:boolean" use="optional" default="false">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Allow roxie to load, run, add queries meant to be run 1 time (no file data copies for these queries</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="callbackRetries" type="xs:nonNegativeInteger" use="optional" default="3">
       <xs:annotation>
         <xs:appinfo>
@@ -540,20 +533,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="deleteUnneededFiles" type="xs:boolean" use="optional" default="false">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>delete data files and query dlls when query is deleted from roxie</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
-    <xs:attribute name="enableForceKeyDiffCopy" type="xs:boolean" use="optional" default="false">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Enable / Disable always copying key diff files to roxie.</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="enableKeyDiff" type="xs:boolean" use="optional" default="true">
       <xs:annotation>
         <xs:appinfo>
@@ -568,13 +547,6 @@
             </xs:appinfo>
         </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="enableSNMP" type="xs:boolean" use="optional" default="true">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Enable SNMP monitoring/control interface</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="flushJHtreeCacheOnOOM" type="xs:boolean" use="optional" default="true">
       <xs:annotation>
         <xs:appinfo>
@@ -704,13 +676,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="resolveFilesInPackage" type="xs:boolean" use="optional" default="false">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Allow for resolving of file references in a package, but not known to roxie.</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="serverThreads" type="xs:nonNegativeInteger" use="optional" default="30">
       <xs:annotation>
         <xs:appinfo>
@@ -1065,13 +1030,6 @@
     </xs:attribute>
   </xs:attributeGroup>
   <xs:attributeGroup name="Debug">
-    <xs:attribute name="channel0onPrimary" type="xs:boolean" use="optional" default="true">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Will favor primary agents to handle requests multicasted on channel 0 </tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="checkCompleted" type="xs:boolean" use="optional" default="true">
       <xs:annotation>
         <xs:appinfo>
@@ -1079,13 +1037,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-      <xs:attribute name="checkingHeap" type="xs:nonNegativeInteger" use="optional" default="0">
-          <xs:annotation>
-              <xs:appinfo>
-                  <tooltip>Use additional checks in roxie heap to detect corruption, overwrites, use after release etc (slow). Level 2 is VERY slow</tooltip>
-              </xs:appinfo>
-          </xs:annotation>
-      </xs:attribute>
       <xs:attribute name="checkPrimaries" type="xs:boolean" use="optional" default="true">
       <xs:annotation>
         <xs:appinfo>
@@ -1093,13 +1044,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="checkVersion" type="xs:boolean" use="optional" default="true">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>check compiled version of dll before loading it</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="dafilesrvLookupTimeout" type="xs:nonNegativeInteger" use="optional" default="10000">
       <xs:annotation>
         <xs:appinfo>
@@ -1156,13 +1100,6 @@
               </xs:appinfo>
           </xs:annotation>
       </xs:attribute>
-      <xs:attribute name="diskReadStable" type="xs:boolean" use="optional" default="true">
-          <xs:annotation>
-              <xs:appinfo>
-                  <tooltip>Force diskreads to return in stable order</tooltip>
-              </xs:appinfo>
-          </xs:annotation>
-      </xs:attribute>
       <xs:attribute name="doIbytiDelay" type="xs:boolean" use="optional" default="true">
       <xs:annotation>
         <xs:appinfo>
@@ -1205,13 +1142,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="indexReadStable" type="xs:boolean" use="optional" default="true">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Force indexreads to return in stable order</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="initIbytiDelay" type="xs:nonNegativeInteger" use="optional" default="100">
       <xs:annotation>
         <xs:appinfo>
@@ -1226,20 +1156,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="keyedJoinFlowLimit" type="xs:nonNegativeInteger" use="optional" default="1000">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Number of keyed join groups permitted (per active activity) before blocking</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
-    <xs:attribute name="keyedJoinStable" type="xs:boolean" use="optional" default="true">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Force keyed joins to return results in stable order</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="linuxYield" type="xs:boolean" use="optional" default="false">
       <xs:annotation>
         <xs:appinfo>
@@ -1324,13 +1240,6 @@
         </xs:appinfo>
       </xs:annotation>
     </xs:attribute>
-    <xs:attribute name="smartSteppingChunkRows" type="xs:nonNegativeInteger" use="optional" default="100">
-      <xs:annotation>
-        <xs:appinfo>
-          <tooltip>Fetch up to N rows per request when global-smartstepping</tooltip>
-        </xs:appinfo>
-      </xs:annotation>
-    </xs:attribute>
     <xs:attribute name="socketCheckInterval" type="xs:nonNegativeInteger" use="optional" default="5000">
       <xs:annotation>
         <xs:appinfo>

+ 0 - 13
initfiles/etc/DIR_NAME/environment.xml.in

@@ -754,7 +754,6 @@
              program="${EXEC_PATH}/ftslave"/>
   </FTSlaveProcess>
   <RoxieCluster allFilesDynamic="true"
-                allowRoxieOnDemand="false"
                 baseDataDir="${RUNTIME_PATH}/hpcc-data/roxie"
                 blindLogging="false"
                 blobCacheMem="0"
@@ -762,12 +761,9 @@
                 buildSet="roxie"
                 callbackRetries="3"
                 callbackTimeout="500"
-                channel0onPrimary="true"
                 checkCompleted="true"
                 checkFileDate="true"
-                checkingHeap="0"
                 checkPrimaries="true"
-                checkVersion="true"
                 clusterWidth="1"
                 copyResources="false"
                 crcResources="false"
@@ -788,16 +784,12 @@
                 defaultSLAPriorityTimeLimit="0"
                 defaultSLAPriorityTimeWarning="5000"
                 defaultStripLeadingWhitespace="1"
-                deleteUnneededFiles="false"
                 description="Roxie cluster"
                 directory="${RUNTIME_PATH}/myroxie"
                 diskReadBufferSize="65536"
-                diskReadStable="true"
                 doIbytiDelay="true"
-                enableForceKeyDiffCopy="false"
                 enableHeartBeat="true"
                 enableKeyDiff="true"
-                enableSNMP="true"
                 enableSysLog="true"
                 fastLaneQueue="true"
                 fieldTranslationEnabled="false"
@@ -806,11 +798,8 @@
                 highTimeout="2000"
                 ignoreMissingFiles="false"
                 indexReadChunkSize="60000"
-                indexReadStable="true"
                 initIbytiDelay="100"
                 jumboFrames="false"
-                keyedJoinFlowLimit="1000"
-                keyedJoinStable="true"
                 lazyOpen="smart"
                 leafCacheMem="50"
                 linuxYield="false"
@@ -850,7 +839,6 @@
                 preferredSubnetMask=""
                 preloadOnceData="true"
                 remoteFilesExpire="3600000"
-                resolveFilesInPackage="false"
                 roxieMulticastEnabled="true"
                 serverSideCacheSize="0"
                 serverThreads="30"
@@ -859,7 +847,6 @@
                 slaTimeout="2000"
                 slaveConfig="simple"
                 slaveThreads="30"
-                smartSteppingChunkRows="100"
                 soapTraceLevel="1"
                 socketCheckInterval="5000"
                 SSHidentityfile="$HOME/.ssh/id_rsa"

+ 0 - 6
roxie/ccd/ccd.hpp

@@ -339,14 +339,12 @@ extern unsigned initIbytiDelay;
 extern unsigned minIbytiDelay;
 extern bool copyResources;
 extern bool chunkingHeap;
-extern unsigned keyedJoinFlowLimit;
 extern unsigned perChannelFlowLimit;
 extern unsigned parallelLoopFlowLimit;
 extern unsigned numServerThreads;
 extern unsigned numRequestArrayThreads;
 extern unsigned readTimeout;
 extern unsigned indexReadChunkSize;
-extern unsigned smartSteppingChunkRows;
 extern SocketEndpoint ownEP;
 extern unsigned maxBlockSize;
 extern unsigned maxLockAttempts;
@@ -359,7 +357,6 @@ extern unsigned socketCheckInterval;
 extern memsize_t defaultMemoryLimit;
 extern unsigned defaultTimeLimit[3];
 extern unsigned defaultWarnTimeLimit[3];
-extern bool deleteUnneededFiles;
 extern bool checkPrimaries;
 extern bool pretendAllOpt;
 extern ClientCertificate clientCert;
@@ -374,7 +371,6 @@ extern unsigned preabortIndexReadsThreshold;
 extern bool traceStartStop;
 extern bool traceServerSideCache;
 extern bool timeActivities;
-extern int defaultCheckingHeap;
 extern unsigned watchActivityId;
 extern unsigned testSlaveFailure;
 extern unsigned dafilesrvLookupTimeout;
@@ -383,7 +379,6 @@ extern unsigned mtu_size;
 extern StringBuffer fileNameServiceDali;
 extern StringBuffer roxieName;
 extern bool trapTooManyActiveQueries;
-extern bool allowRoxieOnDemand;
 extern unsigned maxEmptyLoopIterations;
 extern unsigned maxGraphLoopIterations;
 extern HardwareInfo hdwInfo;
@@ -395,7 +390,6 @@ extern bool probeAllRows;
 extern bool steppingEnabled;
 extern bool simpleLocalKeyedJoins;
 extern bool enableKeyDiff;
-extern bool enableForceKeyDiffCopy;
 extern bool useTreeCopy;
 extern PTreeReaderOptions defaultXmlReadFlags;
 extern bool mergeSlaveStatistics;

+ 1 - 14
roxie/ccd/ccdmain.cpp

@@ -59,7 +59,6 @@ unsigned numSlaveThreads = 30;
 unsigned numRequestArrayThreads = 5;
 unsigned headRegionSize;
 bool enableHeartBeat = true;
-unsigned keyedJoinFlowLimit = 1000;
 unsigned parallelLoopFlowLimit = 100;
 unsigned perChannelFlowLimit = 10;
 time_t startupTime;
@@ -67,11 +66,8 @@ unsigned statsExpiryTime = 3600;
 unsigned miscDebugTraceLevel = 0;  // separate trace settings purely for debugging specific items (i.e. all possible locations to look for files at startup)
 unsigned readTimeout = 300;
 unsigned indexReadChunkSize = 60000;
-unsigned smartSteppingChunkRows = 100;
 unsigned maxBlockSize = 10000000;
 unsigned maxLockAttempts = 5;
-bool checkVersion = true;
-bool deleteUnneededFiles = true;
 bool checkPrimaries = true;
 bool pretendAllOpt = false;
 bool traceStartStop = false;
@@ -107,7 +103,6 @@ unsigned initIbytiDelay; // In MillSec
 unsigned minIbytiDelay;  // In MillSec
 bool copyResources;
 bool enableKeyDiff = true;
-bool enableForceKeyDiffCopy = true;
 bool chunkingHeap = true;
 bool logFullQueries;
 bool blindLogging = false;
@@ -122,7 +117,6 @@ memsize_t defaultMemoryLimit;
 unsigned defaultTimeLimit[3] = {0, 0, 0};
 unsigned defaultWarnTimeLimit[3] = {0, 5000, 5000};
 
-int defaultCheckingHeap = 0;
 unsigned defaultParallelJoinPreload = 0;
 unsigned defaultPrefetchProjectPreload = 10;
 unsigned defaultConcatPreload = 0;
@@ -139,7 +133,6 @@ unsigned mtu_size = 1400; // upper limit on outbound buffer size - allow some he
 StringBuffer fileNameServiceDali;
 StringBuffer roxieName;
 bool trapTooManyActiveQueries;
-bool allowRoxieOnDemand;
 unsigned maxEmptyLoopIterations;
 unsigned maxGraphLoopIterations;
 bool probeAllRows;
@@ -628,7 +621,6 @@ int STARTQUERY_API start_query(int argc, const char *argv[])
         lowTimeout = topology->getPropInt("@lowTimeout", 10000);
         highTimeout = topology->getPropInt("@highTimeout", 2000);
         slaTimeout = topology->getPropInt("@slaTimeout", 2000);
-        keyedJoinFlowLimit = topology->getPropInt("@keyedJoinFlowLimit", 1000);
         parallelLoopFlowLimit = topology->getPropInt("@parallelLoopFlowLimit", 100);
         perChannelFlowLimit = topology->getPropInt("@perChannelFlowLimit", 10);
         copyResources = topology->getPropBool("@copyResources", true);
@@ -688,7 +680,6 @@ int STARTQUERY_API start_query(int argc, const char *argv[])
             DBGLOG("WARNING: ignoring udpSnifferEnabled setting as multicast not enabled");
 
         indexReadChunkSize = topology->getPropInt("@indexReadChunkSize", 60000);
-        smartSteppingChunkRows = topology->getPropInt("@smartSteppingChunkRows", 100);
         numSlaveThreads = topology->getPropInt("@slaveThreads", 30);
         numServerThreads = topology->getPropInt("@serverThreads", 30);
         numRequestArrayThreads = topology->getPropInt("@requestArrayThreads", 5);
@@ -713,11 +704,9 @@ int STARTQUERY_API start_query(int argc, const char *argv[])
         defaultFullKeyedJoinPreload = topology->getPropInt("@defaultFullKeyedJoinPreload", 0);
         defaultKeyedJoinPreload = topology->getPropInt("@defaultKeyedJoinPreload", 0);
         defaultPrefetchProjectPreload = topology->getPropInt("@defaultPrefetchProjectPreload", 10);
+        diskReadBufferSize = topology->getPropInt("@diskReadBufferSize", 0x10000);
         fieldTranslationEnabled = topology->getPropBool("@fieldTranslationEnabled", false);
 
-        defaultCheckingHeap = topology->getPropInt("@checkingHeap", 0);
-        checkVersion = topology->getPropBool("@checkVersion", true);
-        deleteUnneededFiles = topology->getPropBool("@deleteUnneededFiles", true);
         checkPrimaries = topology->getPropBool("@checkPrimaries", true);
         pretendAllOpt = topology->getPropBool("@ignoreMissingFiles", false);
         memoryStatsInterval = topology->getPropInt("@memoryStatsInterval", 60);
@@ -746,14 +735,12 @@ int STARTQUERY_API start_query(int argc, const char *argv[])
         dafilesrvLookupTimeout = topology->getPropInt("@dafilesrvLookupTimeout", 10000);
         topology->getProp("@daliServers", fileNameServiceDali);
         trapTooManyActiveQueries = topology->getPropBool("@trapTooManyActiveQueries", true);
-        allowRoxieOnDemand = topology->getPropBool("@allowRoxieOnDemand", false);
         maxEmptyLoopIterations = topology->getPropInt("@maxEmptyLoopIterations", 1000);
         maxGraphLoopIterations = topology->getPropInt("@maxGraphLoopIterations", 1000);
         useTreeCopy = topology->getPropBool("@useTreeCopy", true);
         mergeSlaveStatistics = topology->getPropBool("@mergeSlaveStatistics", true);
 
         enableKeyDiff = topology->getPropBool("@enableKeyDiff", true);
-        enableForceKeyDiffCopy = topology->getPropBool("@enableForceKeyDiffCopy", false);
 
         // MORE: Get parms from topology after it is populated from Hardware/computer types section in configenv
         //       Then if does not match and based on desired action in topolgy, either warn, or fatal exit or .... etc

+ 0 - 15
roxie/ccd/ccdstate.cpp

@@ -1367,11 +1367,6 @@ private:
             {
                 reply.appendf("<Alive restarts='%d'/>", restarts);
             }
-            else if (stricmp(queryName, "control:allowRoxieOnDemand")==0)
-            {
-                allowRoxieOnDemand= control->getPropBool("@val", true);
-                topology->setPropBool("@allowRoxieOnDemand", allowRoxieOnDemand);
-            }
             else
                 unknown = true;
             break;
@@ -1425,11 +1420,6 @@ private:
                 dafilesrvLookupTimeout = control->getPropInt("@val", 10000);
                 topology->setPropInt("@dafilesrvLookupTimeout", dafilesrvLookupTimeout);
             }
-            else if (stricmp(queryName, "control:defaultCheckingHeap")==0)
-            {
-                defaultCheckingHeap = control->getPropInt("@val", false);
-                topology->setPropInt("@checkingHeap", defaultCheckingHeap);
-            }
             else if (stricmp(queryName, "control:defaultConcatPreload")==0)
             {
                 defaultConcatPreload = control->getPropInt("@val", 0);
@@ -1512,11 +1502,6 @@ private:
                 enableKeyDiff = control->getPropBool("@val", true);
                 topology->setPropBool("@enableKeyDiff", enableKeyDiff);
             }
-            else if (stricmp(queryName, "control:enableForceKeyDiffCopy")==0)
-            {
-                enableForceKeyDiffCopy = control->getPropBool("@val", false);
-                topology->setPropBool("@enableForceKeyDiffCopy", enableForceKeyDiffCopy);
-            }
             else
                 unknown = true;
             break;