HPCC-25107 Excessive tracing of plugin loads

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>

common/dllserver/thorplugin.cpp

@@ -285,13 +285,14 @@ public:
 class HelperDll : implements ILoadedDllEntry, public CInterface
 {
     SharedObject so;
-    StringAttr name;
     Linked<const IFileIO> dllFile;
     Owned<IMemoryMappedFile> mappedDll;
     mutable std::atomic<IPropertyTree *> manifest {nullptr};
     mutable CriticalSection manifestLock;
     mutable StringMapOf<ManifestFileList> manifestFiles;
 
+protected:
+    StringAttr name;
     bool logLoad;
 public:
     IMPLEMENT_IINTERFACE;
@@ -325,8 +326,8 @@ public:
 
     bool init(IPluginContextEx * pluginCtx);
 
-    virtual bool checkVersion(const char *expected);
-    virtual void logLoaded();
+    virtual bool checkVersion(const char *expected) override;
+    virtual void logLoaded() override;
 };
 
 HelperDll::HelperDll(const char *_name, const IFileIO *_dllFile)
@@ -603,17 +604,8 @@ bool PluginDll::checkVersion(const char *expected)
 
 void PluginDll::logLoaded()
 {
-    HelperDll::logLoaded();
-    DBGLOG("Current reported version is %s", pb.version);
-    if (pb.compatibleVersions)
-    {
-        const char **finger = pb.compatibleVersions;
-        while (*finger)
-        {
-            DBGLOG("Compatible version %s", *finger);
-            finger++;
-        }
-    }
+    logLoad = true;
+    DBGLOG("Loaded DLL %s [%s]", name.get(), pb.version);
 }
 
 extern DLLSERVER_API ILoadedDllEntry * createDllEntry(const char *path, bool isGlobal, const IFileIO *dllFile, bool resourcesOnly)

plugins/exampleplugin/exampleplugin.cpp

@@ -40,7 +40,7 @@ ECL_EXAMPLE_PLUGIN_API bool getECLPluginDefinition(ECLPluginDefinitionBlock *pb)
     pb->moduleName = "lib_redis";
     pb->ECL = NULL;
     pb->flags = PLUGIN_IMPLICIT_MODULE;
-    pb->description = "ECL plugin library for BLAH BLAH BLAH\n";
+    pb->description = "ECL plugin library for BLAH BLAH BLAH";
     return true;
 }
 

plugins/h3/h3.cpp

@@ -39,7 +39,7 @@ ECL_H3_API bool getECLPluginDefinition(ECLPluginDefinitionBlock *pb)
     pb->moduleName = "lib_h3";
     pb->ECL = NULL;
     pb->flags = PLUGIN_IMPLICIT_MODULE;
-    pb->description = "ECL plugin library for uber h3\n";
+    pb->description = "ECL plugin library for uber h3";
     return true;
 }
 

plugins/kafka/kafka.cpp

@@ -1092,7 +1092,7 @@ ECL_KAFKA_API bool getECLPluginDefinition(ECLPluginDefinitionBlock* pb)
     pb->moduleName = "kafka";
     pb->ECL = NULL;
     pb->flags = PLUGIN_IMPLICIT_MODULE;
-    pb->description = "ECL plugin library for the C++ API in librdkafka++\n";
+    pb->description = "ECL plugin library for the C++ API in librdkafka++";
 
     return true;
 }

plugins/memcached/memcachedplugin.cpp

@@ -36,7 +36,7 @@ ECL_MEMCACHED_API bool getECLPluginDefinition(ECLPluginDefinitionBlock *pb)
     pb->moduleName = "lib_memcached";
     pb->ECL = NULL;
     pb->flags = PLUGIN_IMPLICIT_MODULE;
-    pb->description = "ECL plugin library for the C/C++ API libmemcached (http://libmemcached.org/)\n";
+    pb->description = "ECL plugin library for the C/C++ API libmemcached (http://libmemcached.org/)";
     return true;
 }
 

plugins/redis/redis.cpp

@@ -37,7 +37,7 @@ ECL_REDIS_API bool getECLPluginDefinition(ECLPluginDefinitionBlock *pb)
     pb->moduleName = "lib_redis";
     pb->ECL = nullptr;
     pb->flags = PLUGIN_IMPLICIT_MODULE;
-    pb->description = "ECL plugin library for the C API hiredis\n";
+    pb->description = "ECL plugin library for the C API hiredis";
     return true;
 }