Ver código fonte

HPCC-16811 Changes following review

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Gavin Halliday 8 anos atrás
pai
commit
41d3331910
1 arquivos alterados com 2 adições e 4 exclusões
  1. 2 4
      rtl/eclrtl/rtlfield.cpp

+ 2 - 4
rtl/eclrtl/rtlfield.cpp

@@ -1225,14 +1225,12 @@ size32_t RtlRecordTypeInfo::build(ARowBuilder &builder, size32_t offset, const R
 
 void RtlRecordTypeInfo::getUtf8(size32_t & resultLen, char * & result, const void * ptr) const
 {
-    //MORE: Should this fail instead?
     resultLen = 0;
     result = nullptr;
 }
 
 __int64 RtlRecordTypeInfo::getInt(const void * ptr) const
 {
-    //MORE: Should this fail instead?
     return 0;
 }
 
@@ -1750,14 +1748,14 @@ size32_t RtlUnimplementedTypeInfo::toXML(const byte * self, const byte * selfrow
 
 void RtlUnimplementedTypeInfo::getUtf8(size32_t & resultLen, char * & result, const void * ptr) const
 {
-    //MORE: Should this fail instead?
     resultLen = 0;
     result = nullptr;
+    rtlFailUnexpected();
 }
 
 __int64 RtlUnimplementedTypeInfo::getInt(const void * ptr) const
 {
-    //MORE: Should this fail instead?
+    rtlFailUnexpected();
     return 0;
 }