HPCC-14367 Update based on review

Signed-off-by: Anthony Fishbeck <anthony.fishbeck@lexisnexis.com>

common/workunit/workunit.cpp

@@ -4376,10 +4376,9 @@ public:
         str.set(name.get());
         return str;
     }
-    IStringVal & getAlias(IStringVal & str) const
+    const char *getAlias() const
     {
-        str.set(alias.get());
-        return str;
+        return alias;
     }
     IStringVal & getScope(IStringVal & str) const
     {

common/workunit/workunit.hpp

@@ -527,7 +527,7 @@ interface IConstWUClusterInfo : extends IInterface
     virtual unsigned getRoxieRedundancy() const = 0;
     virtual unsigned getChannelsPerNode() const = 0;
     virtual int getRoxieReplicateOffset() const = 0;
-    virtual IStringVal & getAlias(IStringVal & str) const = 0;
+    virtual const char *getAlias() const = 0;
 };
 
 //! IWorkflowItem

esp/services/ws_ecl/ws_ecl_service.cpp

@@ -284,8 +284,7 @@ bool CWsEclService::init(const char * name, const char * type, IPropertyTree * c
         }
         if (list.length())
         {
-            SCMStringBuffer alias;
-            clusterInfo->getAlias(alias);
+            StringAttr alias(clusterInfo->getAlias());
             Owned<ISmartSocketFactory> sf = new RoxieSocketFactory(list.str(), !loadBalanced, includeTargetInURL, loadBalanced ? alias.str() : NULL);
             connMap.setValue(target.str(), sf.get());
             if (alias.length() && !connMap.getValue(alias.str())) //only need one vip per alias for routing purposes