Merge pull request #15906 from ghalliday/binaryResource

HPCC-27346 Refactor workunit loading in preparation for binary switch

Reviewed-By: Jake Smith <jake.smith@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>

ecl/eclccserver/eclccserver.cpp

@@ -709,7 +709,7 @@ class EclccCompileThread : implements IPooledThread, implements IErrorReporter,
                         workunit->setJobName(jobname);
                     if (!workunit->getDebugValueBool("obfuscateOutput", false))
                     {
-                        StringBuffer wuXML;
+                        StringBuffer wuXML; // Not sure this is a good idea.... better to always get it from the dll resource
                         Owned<IWUQuery> query = workunit->updateQuery();
                         if (getArchiveXMLFromFile(realdllfilename, wuXML.clear()))  // MORE - if what was submitted was an archive, this is probably pointless?
                             query->setQueryText(wuXML.str());

ecl/hqlcpp/hqlecl.cpp

@@ -603,7 +603,7 @@ bool HqlDllGenerator::generateCode(HqlQueryContext & query)
 
 void HqlDllGenerator::addWorkUnitAsResource()
 {
-    bool defaultBinaryWorkunit = false;
+    bool defaultBinaryWorkunit = true;
     if (wu->getDebugValueInt("saveBinaryWorkunit", defaultBinaryWorkunit))
     {
         MemoryBuffer wuBinary;