HPCC-21272 Preserve the case of identifiers in the graph

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>

ecl/hqlcpp/hqlhtcpp.cpp

@@ -1944,16 +1944,14 @@ void ActivityInstance::addNameAttribute(IHqlExpression * symbol)
     //We should probably perform some deduping instead.
     addLocationAttribute(symbol);
 
-    IAtom * name = symbol->queryName();
+    IIdAtom * name = symbol->queryId();
     if (!name)
         return;
 
-    ForEachItemIn(i, names)
-    {
-        if (names.item(i).queryName() == name)
-            return;
-    }
-    names.append(*symbol);
+    if (names.contains(*name))
+        return;
+
+    names.append(*name);
     addAttribute(WaEclName, str(name));
 }
 

ecl/hqlcpp/hqlhtcpp.ipp

@@ -222,7 +222,7 @@ public:
     IHqlStmt * classGroup;
     unsigned    initialGroupMarker;
     HqlExprArray constructorArgs;
-    HqlExprCopyArray names;
+    ICopyArrayOf<IIdAtom> names;
     LocationArray locations;
 
     Linked<IPropertyTree> graphNode;