Pārlūkot izejas kodu

HPCC-26921 Review changes

Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
Jake Smith 3 gadi atpakaļ
vecāks
revīzija
68bf1e650d

+ 0 - 2
thorlcr/activities/keyedjoin/thkeyedjoin.cpp

@@ -303,8 +303,6 @@ public:
         totalIndexParts = 0;
 
         Owned<IDistributedFile> dataFile;
-        
-        
         Owned<IDistributedFile> indexFile = lookupReadFile(indexFileName, false, false, 0 != (helper->getJoinFlags() & JFindexoptional));
         if (indexFile)
         {

+ 1 - 1
thorlcr/graph/thgraphmaster.cpp

@@ -606,7 +606,7 @@ void CMasterActivity::updateFileReadCostStats(std::vector<OwnedPtr<CThorStatsCol
      * NB: also changed when the expansion of readFiles (from supers to subfiles) happens, a new super was being added
      * each CQ iteration and re-expanded, meaing readFiles kept growing.
      * 
-     * Also, superkey1.ecl hits a dbgasserex whilst deserializaing stats (before and after these PR changes),
+     * Also, superkey1.ecl hits a dbgasserex whilst deserializing stats (before and after these PR changes),
      * but is caught/ignored. I haven't investigated further.
      */
 

+ 1 - 1
thorlcr/graph/thgraphmaster.ipp

@@ -240,7 +240,7 @@ class graphmaster_decl CMasterActivity : public CActivityBase, implements IThrea
     MemoryBuffer *data;
     CriticalSection progressCrit;
     IArrayOf<IDistributedFile> readFiles;
-    std::unordered_map<std::string, IDistributedFile *> readFilesMap;
+    std::unordered_map<std::string, IDistributedFile *> readFilesMap; // NB: IDistributedFile pointers are owned by readFiles
 
 protected:
     std::vector<OwnedPtr<CThorEdgeCollection>> edgeStatsVector;