Browse Source

HPCC-12408 Changes following code review

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Gavin Halliday 10 years ago
parent
commit
7cf10959ae
3 changed files with 4 additions and 4 deletions
  1. 2 2
      ecl/hql/hqlexpr.cpp
  2. 1 1
      system/jlib/jhash.cpp
  3. 1 1
      system/jlib/jsuperhash.cpp

+ 2 - 2
ecl/hql/hqlexpr.cpp

@@ -4768,8 +4768,8 @@ CUsedTables::~CUsedTables()
     }
     else if (numTables != 0)
     {
-        for (unsigned i2=numActiveTables; i2 < numTables; i2++)
-            tables.multi[i2]->Release();
+        for (unsigned i=numActiveTables; i < numTables; i++)
+            tables.multi[i]->Release();
         delete [] tables.multi;
     }
 }

+ 1 - 1
system/jlib/jhash.cpp

@@ -99,7 +99,7 @@ unsigned hashc( const unsigned char *k, unsigned length, unsigned initval)
 template <typename T>
 inline unsigned doHashValue( T value, unsigned initval)
 {
-    //If values are to be consistent with hashn() assumes little-endian
+    //The values returned from this function are only consistent with those from hashn() if running on little endian architecture
     unsigned hash = initval;
     unsigned char c;
     for (unsigned i=0; i < sizeof(T); i++)

+ 1 - 1
system/jlib/jsuperhash.cpp

@@ -104,7 +104,7 @@ SuperHashTable::~SuperHashTable()
 void SuperHashTable::dumpStats()
 {
     if (tablecount && search_tot && search_num)
-        printf("Hash table %d entries, %d size, average search length %d(%d/%d)) max %d\n", tablecount, tablesize,
+        printf("Hash table %d entries, %d size, average search length %d(%d/%d) max %d\n", tablecount, tablesize,
                (int) (search_tot/search_num), search_tot, search_num, search_max);
 }
 #endif