瀏覽代碼

HPCC-18783 Inconsistent overrides in cppdataset.ecl

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Richard Chapman 7 年之前
父節點
當前提交
c206a4b813
共有 3 個文件被更改,包括 6 次插入6 次删除
  1. 2 2
      testing/regress/ecl/cppdataset.ecl
  2. 2 2
      testing/regress/ecl/normalize4.ecl
  3. 2 2
      testing/regress/ecl/streamread.ecl

+ 2 - 2
testing/regress/ecl/cppdataset.ecl

@@ -86,7 +86,7 @@ public:
     }
     RTLIMPLEMENT_IINTERFACE
 
-    virtual const void *nextRow()
+    virtual const void *nextRow() override
     {
         const char * const names[] = {"Gavin","John","Bart"};
         if (count >= numElements(names))
@@ -103,7 +103,7 @@ public:
         memcpy(row+sizeof(size32_t)+lenPrefix, name, lenName);
         return rowBuilder.finalizeRowClear(len);
     }
-    virtual void stop()
+    virtual void stop() override
     {
         count = (unsigned)-1;
     }

+ 2 - 2
testing/regress/ecl/normalize4.ecl

@@ -56,7 +56,7 @@ streamed dataset(out1Rec) extractResult3(doneRec done) := BEGINC++
         myStream(IEngineRowAllocator * _allocator, unsigned _id) : allocator(_allocator), id(_id), idx(0) {}
         RTLIMPLEMENT_IINTERFACE
 
-        virtual const void *nextRow()
+        virtual const void *nextRow() override
         {
             if (idx >= 10)
                return NULL;
@@ -65,7 +65,7 @@ streamed dataset(out1Rec) extractResult3(doneRec done) := BEGINC++
             *(unsigned __int64 *)row = id + ++idx;
             return allocator->finalizeRow(allocSize, row, allocSize);
         }
-        virtual void stop() {}
+        virtual void stop() override {}
     private:
         Linked<IEngineRowAllocator> allocator;
         unsigned id;

+ 2 - 2
testing/regress/ecl/streamread.ecl

@@ -41,7 +41,7 @@ streamed dataset(outRecord) doRead(const varstring name) := EMBED(C++ : distribu
         }
         RTLIMPLEMENT_IINTERFACE
 
-        virtual const void * nextRow()
+        virtual const void * nextRow() override
         {
             if (idx >= sizeof(rows)/sizeof(*rows))
                 return NULL;
@@ -51,7 +51,7 @@ streamed dataset(outRecord) doRead(const varstring name) := EMBED(C++ : distribu
             return builder.finalizeRowClear(11);
         }
 
-        virtual void stop()
+        virtual void stop() override
         {
         }