Merge pull request #5457 from ghalliday/issue10918

HPCC-10918 Fix build break on windows system

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>

common/workunit/referencedfilelist.cpp

@@ -41,7 +41,7 @@ bool checkForeign(const char *lfn)
     if (*lfn=='~')
         lfn++;
     static size_t l = strlen("foreign");
-    if (strncasecmp("foreign", lfn, l)==0)
+    if (strnicmp("foreign", lfn, l)==0)
     {
         lfn+=l;
         while (isspace(*lfn))

deployment/deployutils/confighelper.cpp

@@ -183,7 +183,7 @@ void CConfigHelper::appendBuildSetFromPlugins()
 
     ForEach(*pluginFiles)
     {
-        if (pluginFiles->query().isDirectory() == true)
+        if (pluginFiles->query().isDirectory() == foundYes)
         {
             StringBuffer strPluginBuildSetPath;
 
@@ -322,7 +322,7 @@ void CConfigHelper::addPluginsToConfigGenCompList(IPropertyTree *pCGenComplist,
 
     ForEach(*pluginFiles)
     {
-        if (pluginFiles->query().isDirectory() == true)
+        if (pluginFiles->query().isDirectory() == foundYes)
         {
             StringBuffer strPluginCGenCompListPath;
 
@@ -422,7 +422,7 @@ void CConfigHelper::addPluginsToGenEnvRules(IProperties *pGenEnvRulesProps) cons
 
     ForEach(*pluginFiles)
     {
-        if (pluginFiles->query().isDirectory() == true)
+        if (pluginFiles->query().isDirectory() == foundYes)
         {
             StringBuffer strPluginGenEnvRulesPath;