فهرست منبع

Merge pull request #15006 from mckellyln/hpcc-25970

HPCC-25970 Coverity scan mtls socket uninitialized members

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Richard Chapman 4 سال پیش
والد
کامیت
e510952539
3فایلهای تغییر یافته به همراه6 افزوده شده و 6 حذف شده
  1. 2 2
      system/jlib/jsocket.cpp
  2. 1 1
      system/jlib/jsocket.hpp
  3. 3 3
      system/security/securesocket/securesocket.cpp

+ 2 - 2
system/jlib/jsocket.cpp

@@ -387,8 +387,8 @@ protected:
 
     MCASTREQ    *   mcastreq;
     size32_t        nextblocksize;
-    unsigned        blockflags;
-    unsigned        blocktimeoutms;
+    unsigned        blockflags = BF_ASYNC_TRANSFER;
+    unsigned        blocktimeoutms = WAIT_FOREVER;
     bool            owned;
     enum            {accept_not_cancelled, accept_cancel_pending, accept_cancelled} accept_cancel_state;
     bool            in_accept;

+ 1 - 1
system/jlib/jsocket.hpp

@@ -710,7 +710,7 @@ public:
     Owned<ISocket> sock;
     Owned<ISocket> listensock;
     enum { Snone, Saccept, Sconnect, Srecv, Ssend, Scancelled } state;
-    bool cancelling;
+    bool cancelling = false;
     SocketEndpoint ep;
     CriticalSection crit;
     IMPLEMENT_IINTERFACE;

+ 3 - 3
system/security/securesocket/securesocket.cpp

@@ -138,9 +138,9 @@ private:
     CStringSet* m_peers;
     int         m_loglevel;
     bool        m_isSecure;
-    size32_t    nextblocksize;
-    unsigned    blockflags;
-    unsigned    blocktimeoutms;
+    size32_t    nextblocksize = 0;
+    unsigned    blockflags = BF_ASYNC_TRANSFER;
+    unsigned    blocktimeoutms = WAIT_FOREVER;
 #ifdef USERECVSEM
     static Semaphore receiveblocksem;
     bool             receiveblocksemowned; // owned by this socket