소스 검색

HPCC-19842 Declare ISecProperty::setValue

Add setValue to the ISecProperty interface. This eliminates the
need to cast to a concrete implementation in order to set a
member, the existence of which is implied by the declared
getValue method.

HPCC-19842 Add override keyword to setValue implementations

Fixed HPCC-19842

Signed-off-by: Tim Klemm <Tim.Klemm@lexisnexisrisk.com>
Tim Klemm 7 년 전
부모
커밋
f55807196a
3개의 변경된 파일3개의 추가작업 그리고 2개의 파일을 삭제
  1. 1 1
      system/security/LdapSecurity/ldapsecurity.ipp
  2. 1 1
      system/security/shared/SecurityResource.hpp
  3. 1 0
      system/security/shared/seclib.hpp

+ 1 - 1
system/security/LdapSecurity/ldapsecurity.ipp

@@ -273,7 +273,7 @@ public:
     virtual void setDescription(const char* description);
     virtual const char* getDescription();
 
-    virtual void setValue(const char* value);
+    virtual void setValue(const char* value) override;
     virtual const char* getValue();
 
     virtual ISecResource * clone();

+ 1 - 1
system/security/shared/SecurityResource.hpp

@@ -99,7 +99,7 @@ public:
         return m_description.str();
     }
 
-    virtual void setValue(const char* Value)
+    virtual void setValue(const char* Value) override
     {
         m_value.clear().append(Value);
     }

+ 1 - 0
system/security/shared/seclib.hpp

@@ -216,6 +216,7 @@ interface ISecAuthenticEvents : extends IInterface
 interface ISecProperty : extends IInterface
 {
     virtual const char * getName() = 0;
+    virtual void setValue(const char * value) = 0;
     virtual const char * getValue() = 0;
 };