소스 검색

HPCC-19021 Fix potential null dereference caught by Coverity

I don't think would cause issues in current usage, but definitely worth
fixing.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Richard Chapman 7 년 전
부모
커밋
fab3af3b0c
1개의 변경된 파일3개의 추가작업 그리고 3개의 파일을 삭제
  1. 3 3
      rtl/eclrtl/rtldynfield.cpp

+ 3 - 3
rtl/eclrtl/rtldynfield.cpp

@@ -36,12 +36,12 @@
 
 extern ECLRTL_API RecordTranslationMode getTranslationMode(const char *val)
 {
-    if (strieq(val, "alwaysDisk"))
+    if (!val || strToBool(val) || strieq(val, "payload"))
+        return RecordTranslationMode::Payload;
+    else if (strieq(val, "alwaysDisk"))
         return RecordTranslationMode::AlwaysDisk;
     else if (strieq(val, "alwaysECL"))
         return RecordTranslationMode::AlwaysECL;
-    else if (!val || strToBool(val) || strieq(val, "payload"))
-        return RecordTranslationMode::Payload;
     else
         return RecordTranslationMode::None;
 }