HPCC-19676 New Defects reported by Coverity Scan for HPCC-Platform 2018-05-14

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>

rtl/eclrtl/rtldynfield.cpp

@@ -850,7 +850,7 @@ private:
                     init = malloc(initLength);
                     memcpy(init, type.readDirect(initLength), initLength);
                 }
-                if (fieldFlags & RFTMhasVirtualInitializer)
+                else if (fieldFlags & RFTMhasVirtualInitializer)
                 {
                     byte virtualKind;
                     type.read(virtualKind);

rtl/eclrtl/rtlrecord.cpp

@@ -633,8 +633,10 @@ RtlRow::RtlRow(const RtlRecord & _info, const void * optRow, unsigned numOffsets
 
 size_t RtlRow::noVariableOffsets [1] = {0};
 
-RtlRow::RtlRow(const RtlRecord & _info) : info(_info), variableOffsets(noVariableOffsets)
+RtlRow::RtlRow(const RtlRecord & _info, const void *_row) : info(_info), variableOffsets(noVariableOffsets)
 {
+    row = (const byte *)_row;
+
 }
 
 __int64 RtlRow::getInt(unsigned field) const
@@ -737,9 +739,8 @@ void RtlRow::lazyCalcOffsets(unsigned _numFieldsUsed) const
 }
 
 RtlFixedRow::RtlFixedRow(const RtlRecord & _info, const void *_row, unsigned _numFieldsUsed)
-: RtlRow(_info)
+: RtlRow(_info, _row)
 {
-    row = (const byte *) _row;
     numFieldsUsed = _numFieldsUsed;
     dbgassertex(info.isFixedOffset(numFieldsUsed));
 }

rtl/eclrtl/rtlrecord.hpp

@@ -294,7 +294,7 @@ public:
     }
     explicit operator bool() { return row != nullptr; }
 protected:
-    RtlRow(const RtlRecord & _info);  // for use by fixed-only case
+    RtlRow(const RtlRecord & _info, const void *_row);  // for use by fixed-only case
 
     const RtlRecord & info;
     const byte * row;