Merge pull request #134 from lwilson/issue-127

Issue 127: Remove trailing whitespace

kubernetes/jupyterhub.yml

@@ -1,20 +1,19 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+# Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
-#  Licensed under the Apache License, Version 2.0 (the "License");
-#  you may not use this file except in compliance with the License.
-#  You may obtain a copy of the License at
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
 #
-#      http://www.apache.org/licenses/LICENSE-2.0
+#     http://www.apache.org/licenses/LICENSE-2.0
 #
-#  Unless required by applicable law or agreed to in writing, software
-#  distributed under the License is distributed on an "AS IS" BASIS,
-#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#  See the License for the specific language governing permissions and
-#  limitations under the License.
-
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 ---
+
 #Playbook for installing JupyterHub v1.1.0 in Omnia
- 
 # Start K8s worker servers
 - hosts: manager
   gather_facts: false

kubernetes/kubeflow.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
 
 ---
 #Playbook for installing Kubeflow v1.0 on Omnia
- 
+
 # Start K8s worker servers
 - hosts: manager
   gather_facts: false

kubernetes/kubernetes.yml

@@ -13,7 +13,7 @@
 #  limitations under the License.
 
 ---
-#Playbook for kubernetes cluster 
+#Playbook for kubernetes cluster
 
 #collect info from everything
 - hosts: all

kubernetes/roles/common/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -57,7 +57,7 @@
   tags: install
 
 - name: install common packages
-  yum: 
+  yum:
     name:
       - yum-plugin-versionlock
       - gcc
@@ -75,7 +75,7 @@
 - name: versionlock kubernetes
   command: yum versionlock kubelet-1.16.7 kubectl-1.16.7 kubeadm-1.16.7
   tags: install
-  
+
 
 - name: install InfiniBand Support
   yum:

kubernetes/roles/computeGPU/tasks/main.yml

@@ -14,8 +14,8 @@
 
 ---
 - name: install Nvidia driver
-  yum: 
-    name: 
+  yum:
+    name:
       - kmod-nvidia
       #- nvidia-x11-drv
     state: present
@@ -42,8 +42,8 @@
   tags: testing
 
 - name: install Nvidia-container-runtime-hook
-  yum: 
-    name: 
+  yum:
+    name:
       #- nvidia-detect
       #- kmod-nvidia-410.73-1.el7_5.elrepo
       - nvidia-container-runtime-hook
@@ -51,7 +51,7 @@
   tags: install
 
 
-# This needs to be done on GPU nodes 
+# This needs to be done on GPU nodes
 #- name: Enable DevicePlugins for all GPU nodes (nvidia-container-runtime-hook)
   #copy: src=nvidia dest=/usr/libexec/oci/hooks.d/ owner=root group=root mode=755
   #tags: install

kubernetes/roles/jupyterhub/tasks/main.yml

@@ -19,8 +19,8 @@
 - name: Helm - Update Repo
   shell: helm repo update
 
-- name: JupyterHub Custom Config (files)  
-  copy: src=jupyter_config.yaml dest=/root/k8s/jupyter_config.yaml owner=root group=root mode=655
- 
+- name: JupyterHub Custom Config (files)
+  copy: src=jupyter_config.yaml dest=/root/k8s/jupyter_config.yaml owner=root group=root mode=0655
+
 - name: jupyterHub deploy
   shell: helm install jupyterhub/jupyterhub  --namespace default --version 0.9.0 --values /root/k8s/jupyter_config.yaml --generate-name --wait --timeout 60m

kubernetes/roles/kubeflow/tasks/main.yml

@@ -14,7 +14,7 @@
 
 ---
 
-#Configure build and deploy kubeflow v1.0 
+#Configure build and deploy kubeflow v1.0
 
 - name: Download kfctl v1.0.2 release from the Kubeflow releases page.
   unarchive:
@@ -34,19 +34,19 @@
     recurse: yes
 
 - name: Build Kubeflow Configuration
-  shell: 
+  shell:
     cmd: /usr/bin/kfctl build -V -f https://raw.githubusercontent.com/kubeflow/manifests/v1.0-branch/kfdef/kfctl_k8s_istio.v1.0.2.yaml
     chdir: /root/k8s/omnia-kubeflow
 
-- name: Modify Cpu Limit for istio-ingressgateway-service-account 
+- name: Modify Cpu Limit for istio-ingressgateway-service-account
   replace:
     path: /root/k8s/omnia-kubeflow/kustomize/istio-install/base/istio-noauth.yaml
     after: 'serviceAccountName: istio-ingressgateway-service-account'
     before: '---'
     regexp: 'cpu: 100m'
     replace: 'cpu: 2'
-  
-- name: Modify Mem Limit for istio-ingressgateway-service-account 
+
+- name: Modify Mem Limit for istio-ingressgateway-service-account
   replace:
     path: /root/k8s/omnia-kubeflow/kustomize/istio-install/base/istio-noauth.yaml
     after: 'serviceAccountName: istio-ingressgateway-service-account'
@@ -54,15 +54,15 @@
     regexp: 'memory: 128Mi'
     replace: 'memory: 512Mi'
 
-- name: Modify Cpu Request for istio-ingressgateway-service-account 
+- name: Modify Cpu Request for istio-ingressgateway-service-account
   replace:
     path: /root/k8s/omnia-kubeflow/kustomize/istio-install/base/istio-noauth.yaml
     after: 'serviceAccountName: istio-ingressgateway-service-account'
     before: '---'
     regexp: 'cpu: 10m'
     replace: 'cpu: 1'
-  
-- name: Modify Mem Request for istio-ingressgateway-service-account 
+
+- name: Modify Mem Request for istio-ingressgateway-service-account
   replace:
     path: /root/k8s/omnia-kubeflow/kustomize/istio-install/base/istio-noauth.yaml
     after: 'serviceAccountName: istio-ingressgateway-service-account'
@@ -78,7 +78,7 @@
     before: 'env:'
     regexp: 'cpu: 100m'
     replace: 'cpu: 2'
-  
+
 - name: Modify Mem Limit for kfserving-gateway
   replace:
     path: /root/k8s/omnia-kubeflow/kustomize/kfserving-gateway/base/deployment.yaml
@@ -94,7 +94,7 @@
     before: 'env:'
     regexp: 'cpu: 10m'
     replace: 'cpu: 1'
-  
+
 - name: Modify Mem Request for kfserving-gateway
   replace:
     path: /root/k8s/omnia-kubeflow/kustomize/kfserving-gateway/base/deployment.yaml
@@ -117,6 +117,6 @@
     replace: 'LoadBalancer'
 
 - name: Apply Kubeflow Configuration
-  shell: 
+  shell:
     cmd: /usr/bin/kfctl apply -V -f /root/k8s/omnia-kubeflow/kfctl_k8s_istio.v1.0.2.yaml
     chdir: /root/k8s/omnia-kubeflow

kubernetes/roles/manager/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -35,7 +35,7 @@
   get_url:
     url: https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3
     dest: /root/bin/get_helm.sh
-    mode: 700 
+    mode: 700
   tags: manager
 
 - name: Install Helm

kubernetes/roles/startmanager/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -19,8 +19,8 @@
 
 - name: Initialize kubeadm
   command: /bin/kubeadm init --pod-network-cidr=10.244.0.0/16 --apiserver-advertise-address={{ manager_ip }}
-  #command: /bin/kubeadm init 
-  register: init_output 
+  #command: /bin/kubeadm init
+  register: init_output
   tags: init
 
 - name: Setup Directory for Kubernetes environment for root
@@ -28,11 +28,11 @@
   tags: init
 
 - name: Copy Kubernetes Config for root #do this for other users too?
-  copy: 
-    src: /etc/kubernetes/admin.conf 
-    dest: /root/.kube/config 
-    owner: root 
-    group: root 
+  copy:
+    src: /etc/kubernetes/admin.conf
+    dest: /root/.kube/config
+    owner: root
+    group: root
     mode: 644
     remote_src: yes
   tags: init
@@ -73,7 +73,7 @@
 - name: Setup Calico SDN network
   shell: kubectl apply -f https://docs.projectcalico.org/manifests/calico.yaml
   tags: init
-  
+
 #- name: Setup Flannel SDN network
   #shell: kubectl apply -f https://raw.githubusercontent.com/coreos/flannel/master/Documentation/kube-flannel.yml
   #tags: init
@@ -84,14 +84,14 @@
   register: gpu_enable
   tags: init
 
-- name: Deploy Xilinx Device Plugin 
+- name: Deploy Xilinx Device Plugin
   shell: kubectl create -f https://raw.githubusercontent.com/Xilinx/FPGA_as_a_Service/master/k8s-fpga-device-plugin/fpga-device-plugin.yml
   register: fpga_enable
   tags: init
 
 - name: Create yaml repo for setup
-  file: 
-    path: /root/k8s 
+  file:
+    path: /root/k8s
     state: directory
   tags: init
 
@@ -117,7 +117,7 @@
 
 - name: Edge / Workstation Install allows pods to scheudle on manager
   shell: kubectl taint nodes --all node-role.kubernetes.io/master-
-  when: single_node 
+  when: single_node
   tags: init
 
 

kubernetes/roles/startservices/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Technologies
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -17,7 +17,7 @@
   #shell:  kubectl get pods -n kube-system --no-headers=true | awk '/coredns/{print $1}'|xargs kubectl delete -n kube-system pod
   #tags: init
 
-- name: Wait for CoreDNS to restart 
+- name: Wait for CoreDNS to restart
   shell: kubectl rollout status deployment/coredns -n kube-system
   tags: init
 

kubernetes/roles/startworkers/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.

slurm/roles/slurm-common/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
 ---
 
 - name: install packages for slurm
-  yum: 
+  yum:
     name:
       - munge
       - mariadb
@@ -45,8 +45,8 @@
 
 
 - name: create SLURM Group
-  group: 
-    name: slurm 
+  group:
+    name: slurm
     state: present
   tags: install
 
@@ -69,7 +69,7 @@
   tags: install
 
 - name: give slurm user permission to spool
-  file: 
+  file:
     path: /var/spool/slurm
     owner: slurm
     group: slurm
@@ -78,7 +78,7 @@
     recurse: yes
 
 - name: give slurm user permission to slurmctld
-  file: 
+  file:
     path: /var/run/slurmctld.pid
     owner: slurm
     group: slurm
@@ -86,7 +86,7 @@
     state: touch
 
 - name: give slurm user permission to slurmd
-  file: 
+  file:
     path: /var/run/slurmd.pid
     owner: slurm
     group: slurm
@@ -95,7 +95,7 @@
 
 - name: start munge service
   service:
-    name: munge 
+    name: munge
     state: restarted
     enabled: yes
   tags: install

slurm/roles/slurm-manager/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -18,23 +18,23 @@
   get_url:
     url: "{{ slurm_url }}"
     dest: /root/Downloads/
-    checksum: "{{ slurm_md5 }}" 
+    checksum: "{{ slurm_md5 }}"
   tags: install
 
 - name: Build SLURM RPMs
-  command: rpmbuild -ta /root/Downloads/slurm-20.02.0.tar.bz2 
+  command: rpmbuild -ta /root/Downloads/slurm-20.02.0.tar.bz2
   tags: install
 
 - name: Copy RPMs to NFS share
   copy:
-    src: "{{ item }}" 
+    src: "{{ item }}"
     dest: /home/rpms/
   with_fileglob:
     - /root/rpmbuild/RPMS/x86_64/slurm*20*.rpm
   tags: install
 
 - name: Install SLURM RPMs on Manager
-  yum: 
+  yum:
     name: "{{ item }}"
     #name: "{{ query('fileglob', ['/home/rpms/slurm*20*.rpm']) }}" <-- how it should work to avoid loop
   with_fileglob:
@@ -62,7 +62,7 @@
   tags: install
 
 
-- name: Start MariaDB 
+- name: Start MariaDB
   service:
     name: mariadb
     state: restarted
@@ -92,19 +92,19 @@
   command: sacctmgr -i add account defaultgroup Cluster={{inventory_hostname}} Description="Default Account" Organization="Default Org"
   tags: install
 
-- name: Add root to the Default Account 
+- name: Add root to the Default Account
   command: sacctmgr -i add user root DefaultAccount=defaultgroup
   tags: install
 
 - name: Start slurmctld on Manager
-  service: 
+  service:
     name: slurmctld
     state: restarted
     enabled: yes
   tags: install
 
 - name: Enable Slurmdbd on Manager
-  service: 
+  service:
     name: slurmdbd
     state: restarted
     enabled: yes

slurm/roles/start-slurm-workers/tasks/main.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.

slurm/slurm.yml

@@ -1,4 +1,4 @@
-#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved. 
+#  Copyright 2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -12,7 +12,7 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 ---
-#Playbook for installing Slurm on a cluster 
+#Playbook for installing Slurm on a cluster
 
 #collect info from everything
 - hosts: all