r.viewshed: improve error messages; fix test (set region, delete maps, remove prints)

git-svn-id: https://svn.osgeo.org/grass/grass/trunk@62168 15284696-431f-4ddb-bdfa-cd5b030d7da7

raster/r.viewshed/main.cpp

@@ -175,9 +175,12 @@ int main(int argc, char *argv[])
        the algorithm will work correctly in theory. But this
        requires some changes. To do. */
     if (!(vp.row < hd->nrows && vp.col < hd->ncols)) {
-	G_warning(_("Viewpoint outside grid"));
-	G_warning(_("viewpont: (row=%d, col=%d)"), vp.row, vp.col);
-	G_fatal_error(_("grid: (rows=%d, cols=%d)"), hd->nrows, hd->ncols);
+	/* unfortunately, we don't know the point coordinates now */
+	G_warning(_("Region extent: north=%d, south=%d, east=%d, west=%d"),
+	    hd->window.north, hd->window.south, hd->window.east, hd->window.west);
+	G_warning(_("Region extent: rows=%d, cols=%d"), hd->nrows, hd->ncols);
+	G_warning(_("Viewpont: row=%d, col=%d"), vp.row, vp.col);
+	G_fatal_error(_("Viewpoint outside of computational region"));
     }
 
 

raster/r.viewshed/testsuite/test_r_viewshed.py

@@ -1,15 +1,48 @@
 import grass.gunittest
 from grass.gunittest.gmodules import call_module
 
+
 class TestViewshed(grass.gunittest.TestCase):
 
+    viewshed = 'test_viewshed_from_elevation'
+
+    @classmethod
+    def setUpClass(cls):
+        cls.use_temp_region()
+        cls.runModule('g.region', rast='elevation')
+
+    @classmethod
+    def tearDownClass(cls):
+        cls.del_temp_region()
+
+    def tearDown(cls):
+        """Remove viewshed map after each test method"""
+        # TODO: eventually, removing maps should be handled through testing framework fucntions
+        cls.runModule('g.remove', flags='f', type='rast',
+                      pattern=cls.viewshed)
+
     def test_limits(self):
+        """Test if results is in expected limits"""
         obs_elev = '1.72'
-        viewshed = 'limits_obs_elev'
         self.assertModule('r.viewshed', input='elevation',
-                          coordinates=(634720,216180), output=viewshed, obs_elev=obs_elev)
-        self.assertRasterMinMax(map=viewshed, refmin=0, refmax=180,
-                                msg="Viewing angle above the ground must be between 0 and 180 deg")
+            coordinates=(634720,216180), output=self.viewshed,
+            obs_elev=obs_elev)
+        self.assertRasterMinMax(map=self.viewshed, refmin=0, refmax=180,
+            msg="Viewing angle above the ground must be between 0 and 180 deg")
+
+    def test_limits_extreme_value(self):
+        """Test extremely high observer elevation
+
+        Unfortunatelly, this takes very long time to compute
+        (something like ten times more).
+        """
+        obs_elev = '500000'
+        self.assertModule('r.viewshed', input='elevation',
+            coordinates=(634720,216180), output=self.viewshed,
+            obs_elev=obs_elev)
+        self.assertRasterMinMax(map=self.viewshed, refmin=0, refmax=180,
+            msg="Viewing angle above the ground must be between 0 and 180 deg")
+
 
 class TestViewshedAgainstReference(grass.gunittest.TestCase):
     """
@@ -26,10 +59,15 @@ class TestViewshedAgainstReference(grass.gunittest.TestCase):
     # precision for comparisons
     precision = 0.0001
 
+    # list to hold rasters to be removed
+    # here we accumulate all rasters created during tests
+    # then we remove them at the end in class tear down
+    to_remove = []
+
     @classmethod
     def setUpClass(cls):
         cls.use_temp_region()
-        call_module('g.region', n=216990, s=215520, e=635950, w=633730, res=10)
+        cls.runModule('g.region', n=216990, s=215520, e=635950, w=633730, res=10)
         cls.elevation = 'ref_elevation'
         cls.runModule('r.in.ascii', input='data/elevation.ascii',
                        output=cls.elevation)
@@ -37,7 +75,11 @@ class TestViewshedAgainstReference(grass.gunittest.TestCase):
     @classmethod
     def tearDownClass(cls):
         cls.del_temp_region()
-        cls.runModule('g.remove', flags='f', type='rast', pattern=cls.elevation)
+        cls.runModule('g.remove', flags='f', type='rast',
+                      pattern=cls.elevation)
+        if cls.to_remove:
+            cls.runModule('g.remove', flags='f', type='rast',
+                          pattern=','.join(cls.to_remove))
 
     def test_viewshed(self):
         ref_viewshed = 'reference_viewshed'
@@ -46,18 +88,20 @@ class TestViewshedAgainstReference(grass.gunittest.TestCase):
 
         self.runModule('r.in.ascii',
                        input='data/lake_viewshed.ascii', output=ref_viewshed)
-        print "assertModule..."
+        self.to_remove.append(ref_viewshed)
+
         self.assertModule('r.viewshed', input=self.elevation,
                           coordinates=(634720,216180), output=viewshed, obs_elev=obs_elev)
+        self.to_remove.append(viewshed)
+
         # check we have expected values
-        print "assertRasterMinMax..."
         self.assertRasterMinMax(map=viewshed, refmin=0, refmax=180,
                                 msg="Viewshed in degrees must be between 0 and 180")
         # check against reference data
-        print "assertRastersNoDifference..."
         self.assertRastersNoDifference(actual=viewshed, reference=ref_viewshed,
                                        precision=self.precision)
-        # TODO: add self.assertRasterFitsUnivar()                                      
+        # TODO: add self.assertRasterFitsUnivar()
+
 
 if __name__ == '__main__':
     grass.gunittest.test()