r.terraflow and r.viewshed: using longer names instead of function overloading to fix compilation error with C++11 (reference to is_empty/is_void is ambiguous)

git-svn-id: https://svn.osgeo.org/grass/grass/trunk@58434 15284696-431f-4ddb-bdfa-cd5b030d7da7

raster/r.terraflow/direction.cpp

@@ -53,11 +53,11 @@ encodeDirectionMFD(const genericWindow<elevation_type>& elevwin,
   
   if(!is_nodata(elevwin.get())) {
     dir = 0;
-    if (elevwin.get(5) < elevwin.get() && !is_void(elevwin.get(5))) dir |= 1;
-    if (elevwin.get(3) < elevwin.get() && !is_void(elevwin.get(3))) dir |= 16;
+    if (elevwin.get(5) < elevwin.get() && !elevation_type_is_void(elevwin.get(5))) dir |= 1;
+    if (elevwin.get(3) < elevwin.get() && !elevation_type_is_void(elevwin.get(3))) dir |= 16;
     for(int i=0; i<3; i++) {
-      if(elevwin.get(i) < elevwin.get() && !is_void(elevwin.get(i))) dir |= 32<<i;
-      if(elevwin.get(i+6) < elevwin.get() && !is_void(elevwin.get(6+i))) dir |= 8>>i;
+      if(elevwin.get(i) < elevwin.get() && !elevation_type_is_void(elevwin.get(i))) dir |= 32<<i;
+      if(elevwin.get(i+6) < elevwin.get() && !elevation_type_is_void(elevwin.get(6+i))) dir |= 8>>i;
     }
   }
   

raster/r.terraflow/nodata.cpp

@@ -73,7 +73,7 @@ is_nodata(float x) {
 
 
 int
-is_void(elevation_type el) {
+elevation_type_is_void(elevation_type el) {
   return (el == nodataType::ELEVATION_NODATA);
 }
 

raster/r.terraflow/nodata.h

@@ -37,7 +37,7 @@
 int is_nodata(elevation_type el);
 int is_nodata(int x);
 int is_nodata(float x);
-int is_void(elevation_type el);
+int elevation_type_is_void(elevation_type el);
 
 
 class nodataType : public ijBaseType {

raster/r.viewshed/rbbst.cpp

@@ -104,7 +104,7 @@ RBTree *create_tree(TreeValue tv)
 }
 
 /*LT: not sure if this is correct */
-int is_empty(RBTree * t)
+int rbtree_is_empty(RBTree * t)
 {
     assert(t);
     return (t->root == NIL);

raster/r.viewshed/rbbst.h

@@ -96,7 +96,7 @@ TreeNode *search_for_node_with_key(RBTree * rbt, double key);
 double find_max_gradient_within_key(RBTree * rbt, double key, double angle, double gradient);
 
 /*LT: not sure if this is correct */
-int is_empty(RBTree * t);
+int rbtree_is_empty(RBTree * t);
 
 
 

raster/r.viewshed/statusstructure.cpp

@@ -292,7 +292,7 @@ double find_max_gradient_in_status_struct(StatusList * sl, double dist, double a
     assert(sl);
     /*note: if there is nothing in the status struccture, it means this
        cell is VISIBLE */
-    if (is_empty(sl))
+    if (status_list_is_empty(sl))
 	return SMALLEST_GRADIENT;
     /*it is also possible that the status structure is not empty, but
        there are no events with key < dist ---in this case it returns
@@ -301,9 +301,9 @@ double find_max_gradient_in_status_struct(StatusList * sl, double dist, double a
 }
 
 /*returns true if it is empty */
-int is_empty(StatusList * sl)
+int status_list_is_empty(StatusList * sl)
 {
     assert(sl);
-    return (is_empty(sl->rbt) ||
+    return (rbtree_is_empty(sl->rbt) ||
 	    sl->rbt->root->value.maxGradient == SMALLEST_GRADIENT);
 }

raster/r.viewshed/statusstructure.h

@@ -89,7 +89,7 @@ StatusList *create_status_struct();
 void delete_status_structure(StatusList * sl);
 
 /*returns true is it is empty */
-int is_empty(StatusList * sl);
+int status_list_is_empty(StatusList * sl);
 
 
 /*delete the statusNode with the given key */