Parcourir la source

HPCC-8384 Changes due to comments

Signed-off-by: Renato Golin <rengolin@hpccsystems.com>
Renato Golin il y a 12 ans
Parent
commit
45b55425e5
2 fichiers modifiés avec 7 ajouts et 11 suppressions
  1. 4 4
      deployment/deploy/DeployTask.cpp
  2. 3 7
      esp/bindings/SOAP/xpp/xpp/StartTag.h

+ 4 - 4
deployment/deploy/DeployTask.cpp

@@ -419,12 +419,12 @@ public:
                catch(IException* e)
                {
                  if (!DeleteFile(sb.str()))
-                       WARNLOG("Couldn't delete file %s", sb.str());
+                   WARNLOG("Couldn't delete file %s", sb.str());
                  throw e;
                }
 
                if (!DeleteFile(sb.str()))
-                     WARNLOG("Couldn't delete file %s", sb.str());
+                 WARNLOG("Couldn't delete file %s", sb.str());
               }
            }
 
@@ -466,7 +466,7 @@ public:
 
          //remove incomplete (invalid) output file produced thus far
          if (!DeleteFile(target))
-               WARNLOG("Couldn't delete file %s", target);
+           WARNLOG("Couldn't delete file %s", target);
        }
        catch (...)
        {
@@ -475,7 +475,7 @@ public:
 
          //remove incomplete (invalid) output file produced thus far
          if (!DeleteFile(target))
-               WARNLOG("Couldn't delete file %s", target);
+           WARNLOG("Couldn't delete file %s", target);
        }
        // Prompt to retry on error
        m_errorCode = (DWORD) -1;//don't format m_errorString based on last error

+ 3 - 7
esp/bindings/SOAP/xpp/xpp/StartTag.h

@@ -87,8 +87,7 @@ namespace xpp {
     }
 
     /** @return DO NOT DEALLOCATE RETURN VALUE! */
-    const SXT_CHAR* getType(int index) const {
-      index = index;
+    const SXT_CHAR* getType(int /*index*/) const {
       return _MYT("CDATA");
     }
 
@@ -106,8 +105,7 @@ namespace xpp {
      * always return "CDATA" 
      * @return DO NOT DEALLOCATE RETURN VALUE! 
      */
-    const SXT_CHAR* getType (const SXT_CHAR* qName_) const {
-      qName_ = qName_;
+    const SXT_CHAR* getType (const SXT_CHAR* /*qName_*/) const {
       return _MYT("CDATA");
     }
     
@@ -115,9 +113,7 @@ namespace xpp {
      * always return "CDATA" 
      * @return DO NOT DEALLOCATE RETURN VALUE! 
      */
-    const SXT_CHAR* getType (const SXT_STRING* uri_, const SXT_CHAR* localName_) const {
-      uri_ = uri_;
-      localName_ = localName_;
+    const SXT_CHAR* getType (const SXT_STRING* /*uri_*/, const SXT_CHAR* /*localName_*/) const {
       return _MYT("CDATA");
     }