Sfoglia il codice sorgente

Refactoring github user data view and methods

David Leonard 10 anni fa
parent
commit
b1e36585d0

+ 4 - 3
hackathon_starter/hackathon/scripts/github.py

@@ -11,7 +11,7 @@ import urllib, urllib2, urlparse
 # GITHUB API CONSTANTS #
 ########################
 
-API_BASE_URL = 'https://api.github.com/users/DrkSephy'
+API_BASE_URL = 'https://api.github.com/users/'
 
 AUTHORIZE_URL = 'https://github.com/login/oauth/authorize'
 ACCESS_TOKEN_URL = 'https://github.com/login/oauth/access_token'
@@ -104,7 +104,7 @@ class GithubOauthClient(object):
 
 
 
-def getUserData(clientID, clientSecret):
+def getUserData(user, clientID, clientSecret):
     '''
     Returns data found on a Github User's public profile.
     This includes information such as number of followers,
@@ -138,7 +138,8 @@ def getUserData(clientID, clientSecret):
                 - userData['following']
                     - Number of users being followed
     '''
-    url = API_BASE_URL + '?' + clientID + '&' + clientSecret
+    url = API_BASE_URL + user +  '?' + clientID + '&' + clientSecret
+    print url
     req = requests.get(url)
     jsonList = []
     jsonList.append(json.loads(req.content))

+ 1 - 1
hackathon_starter/hackathon/templates/hackathon/api_examples.html

@@ -4,7 +4,7 @@
 
 
 	<div class="row text-center">
-	    <div class="col-sm-4"><a href="http://127.0.0.1:8000/hackathon/githubResume/">Github Example</a></div>
+	    <div class="col-sm-4"><a href="http://127.0.0.1:8000/hackathon/githubUser/">Github Example</a></div>
 	    <div class="col-sm-4"><a href="http://127.0.0.1:8000/hackathon/steam/">Steam Example</a></div>
 	    <div class="col-sm-4"><a href={{tumblr_url}}>Tumblr Example</a></div>
 	    <!--

+ 3 - 1
hackathon_starter/hackathon/views.py

@@ -285,11 +285,13 @@ def nytimesarticles(request):
 #################
 
 
+
+
 def githubUser(request):
     '''Returns JSON response about a specific Github User'''
 
     parsedData = {}
-    parsedData['userData'] = getUserData(settings.GITHUB_CLIENT_ID, settings.GITHUB_CLIENT_SECRET)
+    parsedData['userData'] = getUserData('DrkSephy', settings.GITHUB_CLIENT_ID, settings.GITHUB_CLIENT_SECRET)
     return JsonResponse({ 'data': parsedData })
 
 def githubTopRepositories(request):