Add IdentityDetector tests

identity.go

@@ -63,9 +63,9 @@ func (id *IdentityDetector) LoadPeopleDict(path string) error {
 	reverse_dict := []string{}
 	size := 0
 	for scanner.Scan() {
-		ids := strings.Split(strings.ToLower(scanner.Text()), "|")
+		ids := strings.Split(scanner.Text(), "|")
 		for _, id := range ids {
-			dict[id] = size
+			dict[strings.ToLower(id)] = size
 		}
 		reverse_dict = append(reverse_dict, ids[0])
 		size += 1

identity_test.go

@@ -0,0 +1,132 @@
+package hercules
+
+import (
+	"io"
+	"path"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"gopkg.in/src-d/go-git.v4/plumbing"
+	"gopkg.in/src-d/go-git.v4/plumbing/object"
+)
+
+func fixtureIdentityDetector() *IdentityDetector {
+	peopleDict := map[string]int{}
+	peopleDict["vadim@sourced.tech"] = 0
+	peopleDict["gmarkhor@gmail.com"] = 0
+	reversePeopleDict := make([]string, 1)
+	reversePeopleDict[0] = "Vadim"
+	id := IdentityDetector{
+		PeopleDict: peopleDict,
+		ReversePeopleDict: reversePeopleDict,
+	}
+	id.Initialize(testRepository)
+	return &id
+}
+
+func TestIdentityDetectorMeta(t *testing.T) {
+	id := fixtureIdentityDetector()
+	assert.Equal(t, id.Name(), "IdentityDetector")
+	assert.Equal(t, len(id.Requires()), 0)
+	assert.Equal(t, len(id.Provides()), 1)
+	assert.Equal(t, id.Provides()[0], "author")
+}
+
+func TestIdentityDetectorConsume(t *testing.T) {
+	commit, _ := testRepository.CommitObject(plumbing.NewHash(
+		"5c0e755dd85ac74584d9988cc361eccf02ce1a48"))
+	deps := map[string]interface{}{}
+	deps["commit"] = commit
+	res, err := fixtureIdentityDetector().Consume(deps)
+	assert.Nil(t, err)
+	assert.Equal(t, res["author"].(int), 0)
+	commit, _ = testRepository.CommitObject(plumbing.NewHash(
+		"8a03b5620b1caa72ec9cb847ea88332621e2950a"))
+	deps["commit"] = commit
+	res, err = fixtureIdentityDetector().Consume(deps)
+	assert.Nil(t, err)
+	assert.Equal(t, res["author"].(int), MISSING_AUTHOR)
+}
+
+func TestLoadPeopleDict(t *testing.T) {
+	id := fixtureIdentityDetector()
+  err := id.LoadPeopleDict(path.Join("test_data", "identities"))
+	assert.Nil(t, err)
+	assert.Equal(t, len(id.PeopleDict), 7)
+	assert.Contains(t, id.PeopleDict, "linus torvalds")
+	assert.Contains(t, id.PeopleDict, "torvalds@linux-foundation.org")
+	assert.Contains(t, id.PeopleDict, "vadim markovtsev")
+	assert.Contains(t, id.PeopleDict, "vadim@sourced.tech")
+	assert.Contains(t, id.PeopleDict, "another@one.com")
+	assert.Contains(t, id.PeopleDict, "máximo cuadros")
+	assert.Contains(t, id.PeopleDict, "maximo@sourced.tech")
+	assert.Equal(t, len(id.ReversePeopleDict), 4)
+	assert.Equal(t, id.ReversePeopleDict[0], "Linus Torvalds")
+	assert.Equal(t, id.ReversePeopleDict[1], "Vadim Markovtsev")
+	assert.Equal(t, id.ReversePeopleDict[2], "Máximo Cuadros")
+	assert.Equal(t, id.ReversePeopleDict[3], "<unmatched>")
+}
+
+/*
+func TestGeneratePeopleDict(t *testing.T) {
+	id := fixtureIdentityDetector()
+	commits := make([]*object.Commit, 0)
+	iter, err := testRepository.CommitObjects()
+	for ; err != io.EOF; commit, err := iter.Next() {
+		if err != nil {
+			panic(err)
+		}
+		commits = append(commits, commit)
+	}
+	id.GeneratePeopleDict(commits)
+}
+*/
+
+func TestGeneratePeopleDict(t *testing.T) {
+	id := fixtureIdentityDetector()
+	commits := make([]*object.Commit, 0)
+	iter, err := testRepository.CommitObjects()
+	commit, err := iter.Next()
+	for ; err != io.EOF; commit, err = iter.Next() {
+		if err != nil {
+			panic(err)
+		}
+		commits = append(commits, commit)
+	}
+	{
+		i := 0
+		for ; commits[i].Author.Name != "Vadim Markovtsev"; i++ {}
+		if i > 0 {
+			commit := commits[0]
+			commits[0] = commits[i]
+			commits[i] = commit
+		}
+		i = 1
+		for ; commits[i].Author.Name != "Alexander Bezzubov"; i++ {}
+		if i > 0 {
+			commit := commits[1]
+			commits[1] = commits[i]
+			commits[i] = commit
+		}
+		i = 2
+		for ; commits[i].Author.Name != "Máximo Cuadros"; i++ {}
+		if i > 0 {
+			commit := commits[2]
+			commits[2] = commits[i]
+			commits[i] = commit
+		}
+	}
+	id.GeneratePeopleDict(commits)
+	assert.True(t, len(id.PeopleDict) >= 7)
+  assert.True(t, len(id.ReversePeopleDict) >= 3)
+	assert.Equal(t, id.PeopleDict["vadim markovtsev"], 0)
+	assert.Equal(t, id.PeopleDict["vadim@sourced.tech"], 0)
+	assert.Equal(t, id.PeopleDict["gmarkhor@gmail.com"], 0)
+	assert.Equal(t, id.PeopleDict["alexander bezzubov"], 1)
+	assert.Equal(t, id.PeopleDict["bzz@apache.org"], 1)
+	assert.Equal(t, id.PeopleDict["máximo cuadros"], 2)
+	assert.Equal(t, id.PeopleDict["mcuadros@gmail.com"], 2)
+	assert.Equal(t, id.ReversePeopleDict[0], "vadim markovtsev|vadim@sourced.tech|gmarkhor@gmail.com")
+	assert.Equal(t, id.ReversePeopleDict[1], "alexander bezzubov|bzz@apache.org")
+	assert.Equal(t, id.ReversePeopleDict[2], "máximo cuadros|mcuadros@gmail.com")
+}

test_data/identities

@@ -0,0 +1,3 @@
+Linus Torvalds|torvalds@linux-foundation.org
+Vadim Markovtsev|vadim@sourced.tech|another@one.com
+Máximo Cuadros|maximo@sourced.tech