Просмотр исходного кода

Merge pull request #61 from src-d/vmarkovtsev-patch-1

Make golint fail the build
Vadim Markovtsev 7 лет назад
Родитель
Сommit
8acebbabb0
2 измененных файлов с 5 добавлено и 1 удалено
  1. 1 1
      .travis.yml
  2. 4 0
      labours.py

+ 1 - 1
.travis.yml

@@ -47,7 +47,7 @@ install:
   - make
 script:
   - go vet ./...
-  - golint ./...
+  - golint -set_exit_status ./...
   - go test -v -cpu=1,2 -coverprofile=coverage.txt -covermode=count gopkg.in/src-d/hercules.v3
   - $GOPATH/bin/hercules version
   - $GOPATH/bin/hercules --burndown --couples --quiet --pb https://github.com/src-d/hercules > 1.pb

+ 4 - 0
labours.py

@@ -913,7 +913,11 @@ def train_embeddings(index, matrix, tmpdir, shard_size=IDEAL_SHARD_SIZE):
         swivel.FLAGS.output_base_path = tmproot
         swivel.FLAGS.loss_multiplier = 1.0 / shard_size
         swivel.FLAGS.num_epochs = num_epochs
+        # Tensorflow 1.5 parses sys.argv unconditionally *applause*
+        argv_backup = sys.argv[1:]
+        del sys.argv[1:]
         swivel.main(None)
+        sys.argv.extend(argv_backup)
         print("Reading Swivel embeddings...")
         embeddings = []
         with open(os.path.join(tmproot, "row_embedding.tsv")) as frow: