uast_test.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469
  1. // +build !disable_babelfish
  2. package uast
  3. import (
  4. "bytes"
  5. "io/ioutil"
  6. "os"
  7. "testing"
  8. "fmt"
  9. "path"
  10. "github.com/gogo/protobuf/proto"
  11. "github.com/stretchr/testify/assert"
  12. "gopkg.in/bblfsh/sdk.v1/uast"
  13. "gopkg.in/src-d/go-git.v4/plumbing"
  14. "gopkg.in/src-d/go-git.v4/plumbing/object"
  15. "gopkg.in/src-d/hercules.v4/internal/core"
  16. "gopkg.in/src-d/hercules.v4/internal/pb"
  17. items "gopkg.in/src-d/hercules.v4/internal/plumbing"
  18. "gopkg.in/src-d/hercules.v4/internal/test"
  19. )
  20. func fixtureUASTExtractor() *Extractor {
  21. exr := Extractor{Endpoint: "0.0.0.0:9432"}
  22. exr.Initialize(test.Repository)
  23. exr.Languages["Python"] = true
  24. return &exr
  25. }
  26. func TestUASTExtractorMeta(t *testing.T) {
  27. exr := fixtureUASTExtractor()
  28. assert.Equal(t, exr.Name(), "UAST")
  29. assert.Equal(t, len(exr.Provides()), 1)
  30. assert.Equal(t, exr.Provides()[0], DependencyUasts)
  31. assert.Equal(t, len(exr.Requires()), 2)
  32. assert.Equal(t, exr.Requires()[0], items.DependencyTreeChanges)
  33. assert.Equal(t, exr.Requires()[1], items.DependencyBlobCache)
  34. opts := exr.ListConfigurationOptions()
  35. assert.Len(t, opts, 5)
  36. assert.Equal(t, opts[0].Name, ConfigUASTEndpoint)
  37. assert.Equal(t, opts[1].Name, ConfigUASTTimeout)
  38. assert.Equal(t, opts[2].Name, ConfigUASTPoolSize)
  39. assert.Equal(t, opts[3].Name, ConfigUASTFailOnErrors)
  40. assert.Equal(t, opts[4].Name, ConfigUASTLanguages)
  41. feats := exr.Features()
  42. assert.Len(t, feats, 1)
  43. assert.Equal(t, feats[0], FeatureUast)
  44. }
  45. func TestUASTExtractorConfiguration(t *testing.T) {
  46. exr := fixtureUASTExtractor()
  47. facts := map[string]interface{}{}
  48. exr.Configure(facts)
  49. facts[ConfigUASTEndpoint] = "localhost:9432"
  50. facts[ConfigUASTTimeout] = 15
  51. facts[ConfigUASTPoolSize] = 7
  52. facts[ConfigUASTLanguages] = "C, Go"
  53. facts[ConfigUASTFailOnErrors] = true
  54. exr.Configure(facts)
  55. assert.Equal(t, exr.Endpoint, facts[ConfigUASTEndpoint])
  56. assert.NotNil(t, exr.Context)
  57. assert.Equal(t, exr.PoolSize, facts[ConfigUASTPoolSize])
  58. assert.True(t, exr.Languages["C"])
  59. assert.True(t, exr.Languages["Go"])
  60. assert.False(t, exr.Languages["Python"])
  61. assert.Equal(t, exr.FailOnErrors, true)
  62. }
  63. func TestUASTExtractorRegistration(t *testing.T) {
  64. summoned := core.Registry.Summon((&Extractor{}).Name())
  65. assert.Len(t, summoned, 1)
  66. assert.Equal(t, summoned[0].Name(), "UAST")
  67. summoned = core.Registry.Summon((&Extractor{}).Provides()[0])
  68. assert.Len(t, summoned, 1)
  69. assert.Equal(t, summoned[0].Name(), "UAST")
  70. }
  71. func TestUASTExtractorConsume(t *testing.T) {
  72. exr := fixtureUASTExtractor()
  73. changes := make(object.Changes, 2)
  74. // 2b1ed978194a94edeabbca6de7ff3b5771d4d665
  75. treeFrom, _ := test.Repository.TreeObject(plumbing.NewHash(
  76. "96c6ece9b2f3c7c51b83516400d278dea5605100"))
  77. treeTo, _ := test.Repository.TreeObject(plumbing.NewHash(
  78. "251f2094d7b523d5bcc60e663b6cf38151bf8844"))
  79. changes[0] = &object.Change{From: object.ChangeEntry{
  80. Name: "analyser.go",
  81. Tree: treeFrom,
  82. TreeEntry: object.TreeEntry{
  83. Name: "analyser.go",
  84. Mode: 0100644,
  85. Hash: plumbing.NewHash("baa64828831d174f40140e4b3cfa77d1e917a2c1"),
  86. },
  87. }, To: object.ChangeEntry{},
  88. }
  89. changes[1] = &object.Change{From: object.ChangeEntry{
  90. Name: "cmd/hercules/main.go",
  91. Tree: treeFrom,
  92. TreeEntry: object.TreeEntry{
  93. Name: "cmd/hercules/main.go",
  94. Mode: 0100644,
  95. Hash: plumbing.NewHash("c29112dbd697ad9b401333b80c18a63951bc18d9"),
  96. },
  97. }, To: object.ChangeEntry{
  98. Name: "cmd/hercules/main.go",
  99. Tree: treeTo,
  100. TreeEntry: object.TreeEntry{
  101. Name: "cmd/hercules/main.go",
  102. Mode: 0100644,
  103. Hash: plumbing.NewHash("f7d918ec500e2f925ecde79b51cc007bac27de72"),
  104. },
  105. },
  106. }
  107. cache := map[plumbing.Hash]*object.Blob{}
  108. hash := plumbing.NewHash("baa64828831d174f40140e4b3cfa77d1e917a2c1")
  109. cache[hash], _ = test.Repository.BlobObject(hash)
  110. hash = plumbing.NewHash("5d78f57d732aed825764347ec6f3ab74d50d0619")
  111. cache[hash], _ = test.Repository.BlobObject(hash)
  112. hash = plumbing.NewHash("c29112dbd697ad9b401333b80c18a63951bc18d9")
  113. cache[hash], _ = test.Repository.BlobObject(hash)
  114. hash = plumbing.NewHash("f7d918ec500e2f925ecde79b51cc007bac27de72")
  115. cache[hash], _ = test.Repository.BlobObject(hash)
  116. deps := map[string]interface{}{}
  117. deps[items.DependencyBlobCache] = cache
  118. deps[items.DependencyTreeChanges] = changes
  119. deps[core.DependencyCommit], _ = test.Repository.CommitObject(
  120. plumbing.NewHash("2b1ed978194a94edeabbca6de7ff3b5771d4d665"))
  121. res, err := exr.Consume(deps)
  122. // Language not enabled
  123. assert.Len(t, res[DependencyUasts], 0)
  124. assert.Nil(t, err)
  125. exr.Languages["Go3000"] = true
  126. res, err = exr.Consume(deps)
  127. // No Go driver
  128. assert.Len(t, res[DependencyUasts], 0)
  129. assert.Nil(t, err)
  130. hash = plumbing.NewHash("5d78f57d732aed825764347ec6f3ab74d50d0619")
  131. changes[1] = &object.Change{From: object.ChangeEntry{}, To: object.ChangeEntry{
  132. Name: "labours.py",
  133. Tree: treeTo,
  134. TreeEntry: object.TreeEntry{
  135. Name: "labours.py",
  136. Mode: 0100644,
  137. Hash: hash,
  138. },
  139. },
  140. }
  141. res, err = exr.Consume(deps)
  142. assert.Nil(t, err)
  143. uasts := res[DependencyUasts].(map[plumbing.Hash]*uast.Node)
  144. assert.Equal(t, len(uasts), 1)
  145. assert.Equal(t, len(uasts[hash].Children), 24)
  146. }
  147. func TestUASTExtractorFork(t *testing.T) {
  148. exr1 := fixtureUASTExtractor()
  149. clones := exr1.Fork(1)
  150. assert.Len(t, clones, 1)
  151. exr2 := clones[0].(*Extractor)
  152. assert.True(t, exr1 == exr2)
  153. exr1.Merge([]core.PipelineItem{exr2})
  154. }
  155. func fixtureUASTChanges() *Changes {
  156. ch := Changes{}
  157. ch.Configure(nil)
  158. ch.Initialize(test.Repository)
  159. return &ch
  160. }
  161. func TestUASTChangesMeta(t *testing.T) {
  162. ch := fixtureUASTChanges()
  163. assert.Equal(t, ch.Name(), "UASTChanges")
  164. assert.Equal(t, len(ch.Provides()), 1)
  165. assert.Equal(t, ch.Provides()[0], DependencyUastChanges)
  166. assert.Equal(t, len(ch.Requires()), 2)
  167. assert.Equal(t, ch.Requires()[0], DependencyUasts)
  168. assert.Equal(t, ch.Requires()[1], items.DependencyTreeChanges)
  169. opts := ch.ListConfigurationOptions()
  170. assert.Len(t, opts, 0)
  171. feats := ch.Features()
  172. assert.Len(t, feats, 1)
  173. assert.Equal(t, feats[0], FeatureUast)
  174. }
  175. func TestUASTChangesRegistration(t *testing.T) {
  176. summoned := core.Registry.Summon((&Changes{}).Name())
  177. assert.Len(t, summoned, 1)
  178. assert.Equal(t, summoned[0].Name(), "UASTChanges")
  179. summoned = core.Registry.Summon((&Changes{}).Provides()[0])
  180. assert.True(t, len(summoned) >= 1)
  181. matched := false
  182. for _, tp := range summoned {
  183. matched = matched || tp.Name() == "UASTChanges"
  184. }
  185. assert.True(t, matched)
  186. }
  187. func TestUASTChangesConsume(t *testing.T) {
  188. uastsArray := []*uast.Node{}
  189. uasts := map[plumbing.Hash]*uast.Node{}
  190. hash := plumbing.NewHash("291286b4ac41952cbd1389fda66420ec03c1a9fe")
  191. uasts[hash] = &uast.Node{}
  192. uasts[hash].InternalType = "uno"
  193. uastsArray = append(uastsArray, uasts[hash])
  194. hash = plumbing.NewHash("c29112dbd697ad9b401333b80c18a63951bc18d9")
  195. uasts[hash] = &uast.Node{}
  196. uasts[hash].InternalType = "dos"
  197. uastsArray = append(uastsArray, uasts[hash])
  198. hash = plumbing.NewHash("baa64828831d174f40140e4b3cfa77d1e917a2c1")
  199. uasts[hash] = &uast.Node{}
  200. uasts[hash].InternalType = "tres"
  201. uastsArray = append(uastsArray, uasts[hash])
  202. hash = plumbing.NewHash("dc248ba2b22048cc730c571a748e8ffcf7085ab9")
  203. uasts[hash] = &uast.Node{}
  204. uasts[hash].InternalType = "quatro"
  205. uastsArray = append(uastsArray, uasts[hash])
  206. changes := make(object.Changes, 3)
  207. treeFrom, _ := test.Repository.TreeObject(plumbing.NewHash(
  208. "a1eb2ea76eb7f9bfbde9b243861474421000eb96"))
  209. treeTo, _ := test.Repository.TreeObject(plumbing.NewHash(
  210. "994eac1cd07235bb9815e547a75c84265dea00f5"))
  211. changes[0] = &object.Change{From: object.ChangeEntry{
  212. Name: "analyser.go",
  213. Tree: treeFrom,
  214. TreeEntry: object.TreeEntry{
  215. Name: "analyser.go",
  216. Mode: 0100644,
  217. Hash: plumbing.NewHash("dc248ba2b22048cc730c571a748e8ffcf7085ab9"),
  218. },
  219. }, To: object.ChangeEntry{
  220. Name: "analyser.go",
  221. Tree: treeTo,
  222. TreeEntry: object.TreeEntry{
  223. Name: "analyser.go",
  224. Mode: 0100644,
  225. Hash: plumbing.NewHash("baa64828831d174f40140e4b3cfa77d1e917a2c1"),
  226. },
  227. }}
  228. changes[1] = &object.Change{From: object.ChangeEntry{}, To: object.ChangeEntry{
  229. Name: "cmd/hercules/main.go",
  230. Tree: treeTo,
  231. TreeEntry: object.TreeEntry{
  232. Name: "cmd/hercules/main.go",
  233. Mode: 0100644,
  234. Hash: plumbing.NewHash("c29112dbd697ad9b401333b80c18a63951bc18d9"),
  235. },
  236. },
  237. }
  238. changes[2] = &object.Change{To: object.ChangeEntry{}, From: object.ChangeEntry{
  239. Name: ".travis.yml",
  240. Tree: treeTo,
  241. TreeEntry: object.TreeEntry{
  242. Name: ".travis.yml",
  243. Mode: 0100644,
  244. Hash: plumbing.NewHash("291286b4ac41952cbd1389fda66420ec03c1a9fe"),
  245. },
  246. },
  247. }
  248. deps := map[string]interface{}{}
  249. deps[DependencyUasts] = uasts
  250. deps[items.DependencyTreeChanges] = changes
  251. ch := fixtureUASTChanges()
  252. ch.cache[changes[0].From.TreeEntry.Hash] = uastsArray[3]
  253. ch.cache[changes[2].From.TreeEntry.Hash] = uastsArray[0]
  254. resultMap, err := ch.Consume(deps)
  255. assert.Nil(t, err)
  256. result := resultMap[DependencyUastChanges].([]Change)
  257. assert.Len(t, result, 3)
  258. assert.Equal(t, result[0].Change, changes[0])
  259. assert.Equal(t, result[0].Before, uastsArray[3])
  260. assert.Equal(t, result[0].After, uastsArray[2])
  261. assert.Equal(t, result[1].Change, changes[1])
  262. assert.Nil(t, result[1].Before)
  263. assert.Equal(t, result[1].After, uastsArray[1])
  264. assert.Equal(t, result[2].Change, changes[2])
  265. assert.Equal(t, result[2].Before, uastsArray[0])
  266. assert.Nil(t, result[2].After)
  267. }
  268. func TestUASTChangesFork(t *testing.T) {
  269. changes1 := fixtureUASTChanges()
  270. changes1.cache[plumbing.ZeroHash] = nil
  271. clones := changes1.Fork(1)
  272. assert.Len(t, clones, 1)
  273. changes2 := clones[0].(*Changes)
  274. assert.False(t, changes1 == changes2)
  275. assert.Equal(t, changes1.cache, changes2.cache)
  276. delete(changes1.cache, plumbing.ZeroHash)
  277. assert.Len(t, changes2.cache, 1)
  278. changes1.Merge([]core.PipelineItem{changes2})
  279. }
  280. func fixtureUASTChangesSaver() *ChangesSaver {
  281. ch := ChangesSaver{}
  282. ch.Initialize(test.Repository)
  283. return &ch
  284. }
  285. func TestUASTChangesSaverMeta(t *testing.T) {
  286. chs := fixtureUASTChangesSaver()
  287. assert.Equal(t, chs.Name(), "UASTChangesSaver")
  288. assert.Equal(t, len(chs.Provides()), 0)
  289. assert.Equal(t, len(chs.Requires()), 1)
  290. assert.Equal(t, chs.Requires()[0], DependencyUastChanges)
  291. opts := chs.ListConfigurationOptions()
  292. assert.Len(t, opts, 1)
  293. assert.Equal(t, opts[0].Name, ConfigUASTChangesSaverOutputPath)
  294. feats := chs.Features()
  295. assert.Len(t, feats, 1)
  296. assert.Equal(t, feats[0], FeatureUast)
  297. assert.Equal(t, chs.Flag(), "dump-uast-changes")
  298. }
  299. func TestUASTChangesSaverConfiguration(t *testing.T) {
  300. facts := map[string]interface{}{}
  301. chs := fixtureUASTChangesSaver()
  302. chs.Configure(facts)
  303. assert.Empty(t, chs.OutputPath)
  304. facts[ConfigUASTChangesSaverOutputPath] = "libre"
  305. chs.Configure(facts)
  306. assert.Equal(t, chs.OutputPath, "libre")
  307. }
  308. func TestUASTChangesSaverRegistration(t *testing.T) {
  309. summoned := core.Registry.Summon((&ChangesSaver{}).Name())
  310. assert.Len(t, summoned, 1)
  311. assert.Equal(t, summoned[0].Name(), "UASTChangesSaver")
  312. leaves := core.Registry.GetLeaves()
  313. matched := false
  314. for _, tp := range leaves {
  315. if tp.Flag() == (&ChangesSaver{}).Flag() {
  316. matched = true
  317. break
  318. }
  319. }
  320. assert.True(t, matched)
  321. }
  322. func TestUASTChangesSaverPayload(t *testing.T) {
  323. chs := fixtureUASTChangesSaver()
  324. deps := map[string]interface{}{}
  325. changes := make([]Change, 1)
  326. deps[DependencyUastChanges] = changes
  327. deps[core.DependencyCommit], _ = test.Repository.CommitObject(
  328. plumbing.NewHash("2b1ed978194a94edeabbca6de7ff3b5771d4d665"))
  329. treeFrom, _ := test.Repository.TreeObject(plumbing.NewHash(
  330. "a1eb2ea76eb7f9bfbde9b243861474421000eb96"))
  331. treeTo, _ := test.Repository.TreeObject(plumbing.NewHash(
  332. "994eac1cd07235bb9815e547a75c84265dea00f5"))
  333. changes[0] = Change{Before: &uast.Node{}, After: &uast.Node{},
  334. Change: &object.Change{From: object.ChangeEntry{
  335. Name: "analyser.go",
  336. Tree: treeFrom,
  337. TreeEntry: object.TreeEntry{
  338. Name: "analyser.go",
  339. Mode: 0100644,
  340. Hash: plumbing.NewHash("dc248ba2b22048cc730c571a748e8ffcf7085ab9"),
  341. },
  342. }, To: object.ChangeEntry{
  343. Name: "analyser.go",
  344. Tree: treeTo,
  345. TreeEntry: object.TreeEntry{
  346. Name: "analyser.go",
  347. Mode: 0100644,
  348. Hash: plumbing.NewHash("334cde09da4afcb74f8d2b3e6fd6cce61228b485"),
  349. },
  350. }}}
  351. chs.Consume(deps)
  352. res := chs.Finalize()
  353. tmpdir, err := ioutil.TempDir("", "hercules-test-")
  354. assert.Nil(t, err)
  355. defer os.RemoveAll(tmpdir)
  356. chs.OutputPath = tmpdir
  357. buffer := &bytes.Buffer{}
  358. chs.Serialize(res, true, buffer)
  359. pbResults := &pb.UASTChangesSaverResults{}
  360. proto.Unmarshal(buffer.Bytes(), pbResults)
  361. assert.Len(t, pbResults.Changes, 1)
  362. assert.Equal(t, pbResults.Changes[0].FileName, "analyser.go")
  363. assert.Equal(t, pbResults.Changes[0].SrcAfter,
  364. path.Join(tmpdir, "0_0_after_334cde09da4afcb74f8d2b3e6fd6cce61228b485.src"))
  365. assert.Equal(t, pbResults.Changes[0].SrcBefore,
  366. path.Join(tmpdir, "0_0_before_dc248ba2b22048cc730c571a748e8ffcf7085ab9.src"))
  367. assert.Equal(t, pbResults.Changes[0].UastAfter,
  368. path.Join(tmpdir, "0_0_after_334cde09da4afcb74f8d2b3e6fd6cce61228b485.pb"))
  369. assert.Equal(t, pbResults.Changes[0].UastBefore,
  370. path.Join(tmpdir, "0_0_before_dc248ba2b22048cc730c571a748e8ffcf7085ab9.pb"))
  371. checkFiles := func() {
  372. files, err := ioutil.ReadDir(tmpdir)
  373. assert.Nil(t, err)
  374. assert.Len(t, files, 4)
  375. names := map[string]int{
  376. "0_0_after_334cde09da4afcb74f8d2b3e6fd6cce61228b485.src": 1,
  377. "0_0_before_dc248ba2b22048cc730c571a748e8ffcf7085ab9.src": 1,
  378. "0_0_after_334cde09da4afcb74f8d2b3e6fd6cce61228b485.pb": 1,
  379. "0_0_before_dc248ba2b22048cc730c571a748e8ffcf7085ab9.pb": 1,
  380. }
  381. matches := 0
  382. for _, fi := range files {
  383. matches += names[fi.Name()]
  384. os.Remove(fi.Name())
  385. }
  386. assert.Equal(t, matches, len(names))
  387. }
  388. checkFiles()
  389. buffer.Truncate(0)
  390. chs.Serialize(res, false, buffer)
  391. assert.Equal(t, buffer.String(), fmt.Sprintf(` - {file: analyser.go, src0: %s/0_0_before_dc248ba2b22048cc730c571a748e8ffcf7085ab9.src, src1: %s/0_0_after_334cde09da4afcb74f8d2b3e6fd6cce61228b485.src, uast0: %s/0_0_before_dc248ba2b22048cc730c571a748e8ffcf7085ab9.pb, uast1: %s/0_0_after_334cde09da4afcb74f8d2b3e6fd6cce61228b485.pb}
  392. `, tmpdir, tmpdir, tmpdir, tmpdir))
  393. checkFiles()
  394. }
  395. func TestUASTChangesSaverConsumeMerge(t *testing.T) {
  396. chs := fixtureUASTChangesSaver()
  397. deps := map[string]interface{}{}
  398. changes := make([]Change, 1)
  399. deps[DependencyUastChanges] = changes
  400. deps[core.DependencyCommit], _ = test.Repository.CommitObject(
  401. plumbing.NewHash("2b1ed978194a94edeabbca6de7ff3b5771d4d665"))
  402. treeFrom, _ := test.Repository.TreeObject(plumbing.NewHash(
  403. "a1eb2ea76eb7f9bfbde9b243861474421000eb96"))
  404. treeTo, _ := test.Repository.TreeObject(plumbing.NewHash(
  405. "994eac1cd07235bb9815e547a75c84265dea00f5"))
  406. changes[0] = Change{Before: &uast.Node{}, After: &uast.Node{},
  407. Change: &object.Change{From: object.ChangeEntry{
  408. Name: "analyser.go",
  409. Tree: treeFrom,
  410. TreeEntry: object.TreeEntry{
  411. Name: "analyser.go",
  412. Mode: 0100644,
  413. Hash: plumbing.NewHash("dc248ba2b22048cc730c571a748e8ffcf7085ab9"),
  414. },
  415. }, To: object.ChangeEntry{
  416. Name: "analyser.go",
  417. Tree: treeTo,
  418. TreeEntry: object.TreeEntry{
  419. Name: "analyser.go",
  420. Mode: 0100644,
  421. Hash: plumbing.NewHash("334cde09da4afcb74f8d2b3e6fd6cce61228b485"),
  422. },
  423. }}}
  424. deps[core.DependencyCommit], _ = test.Repository.CommitObject(
  425. plumbing.NewHash("cce947b98a050c6d356bc6ba95030254914027b1"))
  426. chs.Consume(deps)
  427. assert.Len(t, chs.result, 1)
  428. chs.Consume(deps)
  429. assert.Len(t, chs.result, 2)
  430. deps[core.DependencyCommit], _ = test.Repository.CommitObject(
  431. plumbing.NewHash("dd9dd084d5851d7dc4399fc7dbf3d8292831ebc5"))
  432. chs.Consume(deps)
  433. assert.Len(t, chs.result, 3)
  434. chs.Consume(deps)
  435. assert.Len(t, chs.result, 3)
  436. }
  437. func TestUASTChangesSaverFork(t *testing.T) {
  438. saver1 := fixtureUASTChangesSaver()
  439. clones := saver1.Fork(1)
  440. assert.Len(t, clones, 1)
  441. saver2 := clones[0].(*ChangesSaver)
  442. assert.True(t, saver1 == saver2)
  443. saver1.Merge([]core.PipelineItem{saver2})
  444. }